refactor to fetch variants/packageIds from an async store#1
Open
refactor to fetch variants/packageIds from an async store#1
Conversation
Tasks now store required values as `Property<String>` or other inputs during provideInput, and read those in `taskAction`
dfabulich
force-pushed
the
fix-agp-9-provider-refactor
branch
from
a48a4ff to
f4857ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
This is a stacked PR on top of ndtp#273 designed to bring back features that were lost in the port to AGP 9.0
How have you achieved it?
https://developer.android.com/build/releases/agp-9-0-0-release-notes
The new variant API is asynchronous, using a callback. So I moved the variants and packageId stuff into a
VariantPackageIdStorewhich returnsProviders for all of its data. This required a pretty big refactor to make everything that used this data work properly.I feel a lot less confident in this code than I do about ndtp#273 … it seems hard to test.
Scope of Impact and Testing instructions
Ideally, if we merge this, there will be no breaking changes at all as we add support for AGP 9. But I'm not sure I know how to test to ensure that's true.