Skip to content

test: drop redundant MemorySegment cast on refPrefix(null) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfa1 merged 1 commit into from
Jul 12, 2026
Merged

test: drop redundant MemorySegment cast on refPrefix(null) #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions zstd/src/test/java/io/github/dfa1/zstd/RefPrefixTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void clearingPrefixWithNullCompressesPlainly() {

// When — set then clear the prefix before compressing
cctx.refPrefix(prefix);
cctx.refPrefix((MemorySegment) null);
cctx.refPrefix(null);
long n = cctx.compress(frame, src);

// Then — a plain decoder with no prefix decodes it
Expand Down Expand Up @@ -226,9 +226,9 @@ void refPrefixReturnsTheSameContextForChaining() {

// When setting and then clearing a prefix on both contexts
ZstdCompressContext cSet = cctx.refPrefix(prefix);
ZstdCompressContext cCleared = cctx.refPrefix((MemorySegment) null);
ZstdCompressContext cCleared = cctx.refPrefix(null);
ZstdDecompressContext dSet = dctx.refPrefix(prefix);
ZstdDecompressContext dCleared = dctx.refPrefix((MemorySegment) null);
ZstdDecompressContext dCleared = dctx.refPrefix(null);

// Then every call returns the same instance, for chaining
assertThat(cSet).isSameAs(cctx);
Expand Down
Loading