fix(editions): address PR #320 review findings - #322
Merged
Conversation
- Drop Edition.minVortexVersion: it names the Rust reference's own release train, not vortex-java's, so it was never meaningful here. - Drop WriteOptions#withoutEditionGuard(): the only escape hatch was guard-wide and untracked. Reaching an unstable-family encoding now requires enabling that family's edition explicitly via withEdition(Editions.UNSTABLE_...), which is both narrower and self-documenting. Updates the 9 test call sites that used the old escape hatch to reach fastlanes.delta/vortex.patched. - Implement ReadRegistry's edition-aware "no decoder registered" message, which was documented in the ADR/CHANGELOG/docs but never actually wired into decode()/decodeAsSegment() in the original PR. Add coverage for the core-edition, unstable-edition, and unknown-to-all-editions message branches, plus decodeAsSegment's error path (previously untested). - java.util.Map.of() -> Map.of() (redundant qualification) across 11 files. - Update ADR 0023 and CHANGELOG.md to match the final design; sweep docs/reference.md and docs/compatibility.md for stale references. Addresses the 6 review comments left on #320 (issue #301). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #320 (issue #301), addressing all 6 review comments left on that PR:
Edition.minVortexVersion— it named the Rust reference's own release train, not vortex-java's, so it was never a meaningful value here.WriteOptions#withoutEditionGuard()— the only escape hatch was guard-wide and untracked. Anunstable-family encoding is now reached by enabling that family's edition explicitly viawithEdition(Editions.UNSTABLE_...), which is narrower and self-documenting. Updated the 9 test call sites that used the old escape hatch to reachfastlanes.delta/vortex.patched.ReadRegistry's edition-aware "no decoder registered" message — this was documented in the ADR/CHANGELOG/docs as shipped, but was never actually wired intodecode()/decodeAsSegment()in the original PR. Added test coverage for the core-edition, unstable-edition, and unknown-to-all-editions message branches, plusdecodeAsSegment's error path (previously untested either way).java.util.Map.of()→Map.of()(redundant qualification) across 11 files.docs/reference.md/docs/compatibility.mdfor stale references to the removed API surface.Test plan
./mvnw verify -DskipTests(full reactor compile)./mvnw test(full unit suite)./mvnw verify -pl integration -am -Dit.test="JavaWritesRustReadsIntegrationTest,JavaRoundTripIntegrationTest"./mvnw -pl writer -am test -Dtest="WriterEditionGuardTest,DeltaEncodingTest,WriteOptionsTest"./mvnw javadoc:javadoc -pl core(zero output)minVortexVersion/withoutEditionGuard/isDraft()outside the ADR's own historical narrative🤖 Generated with Claude Code