Skip to content

[WIP] Fix the failing GitHub Actions job Validate SDC (Quartus) Constraints #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devtyagi3909 merged 2 commits into from
Jun 8, 2026
Merged

[WIP] Fix the failing GitHub Actions job Validate SDC (Quartus) Constraints #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b774a
Initial plan
Copilot Jun 8, 2026
f4c0996
fix: resolve SDC validator CI failure
Copilot Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/validate-constraints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,14 @@ jobs:

- name: Run SDC validator
run: |
set +e
tclsh scripts/validate_sdc.tcl --all
rc=$?
set -e
# Exit code 0 = pass, 1 = warnings (allowed), 2 = errors (fail)
if [ "$rc" -eq 2 ]; then
exit 2
fi

- name: Print SDC summary
if: always()
Expand Down
9 changes: 7 additions & 2 deletions scripts/validate_sdc.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@ set warnings 0

proc report {severity lineno msg} {
global errors warnings
set icon [dict get {ERROR "🔴" WARNING "🟡" INFO "🔵"} $severity "·"]
set severity_icons [dict create ERROR "🔴" WARNING "🟡" INFO "🔵"]
if {[dict exists $severity_icons $severity]} {
set icon [dict get $severity_icons $severity]
} else {
set icon "·"
}
if {$lineno > 0} {
puts " $icon \[$severity\] line $lineno: $msg"
} else {
Expand Down Expand Up @@ -101,7 +106,7 @@ proc validate_sdc {filepath} {
}

# Catch common SDC typos
if {[regexp {-period\s+([\d.]+)} $trimmed -> period]} {
if {[regexp -- {-period\s+([\d.]+)} $trimmed -> period]} {
if {$period < 1.0} {
report WARNING $lineno "Very short clock period ${period}ns ([expr {1000.0/$period}] MHz) — verify"
}
Expand Down
Loading