fix: remove identical if/else branch in GetRoleForOtherEntity (#6031) - #7033
Open
absaar-404 wants to merge 1 commit into
Open
fix: remove identical if/else branch in GetRoleForOtherEntity (#6031)#7033absaar-404 wants to merge 1 commit into
absaar-404 wants to merge 1 commit into
Conversation
The 'else if team=="" && app=="" && env=="" && act==""' branch and the following 'else' branch both returned 'model, nil'. Removed the redundant else-if so the final else handles that case. Fixes devtron-labs#6031
absaar-404
requested review from
prakarsh-dt and
vivek-devtron
as code owners
September 11, 2026 02:12
|
Bito Review Skipped - Source Branch Not Found |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
GetRoleForOtherEntity, theelse if team=="" && app=="" && env=="" && act==""branch and the followingelsebranch both returnedmodel, nil. Removed the redundantelse ifso the finalelsehandles that case.Why
Reported by the
revivelinter (identical if/else branches). No behavior change.Fixes #6031