fix: collapse identical if/else branches in AppStoreApplicationVersionRepository.FindWithFilter (#6030) - #7032
Open
absaar-404 wants to merge 1 commit into
Open
Conversation
…ory.FindWithFilter All branches of the if/else-if construct executed the identical statement 'impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...)'. The query and queryParams are fully built beforehand, so the branching on ChartRepoId/RegistryId was dead code. Collapsed to a single call. Fixes devtron-labs#6030
absaar-404
requested review from
prakarsh-dt and
vivek-devtron
as code owners
September 11, 2026 02:11
|
Bito Review Skipped - Source Branch Not Found |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
All branches of the
if/else-ifconstruct inFindWithFilterexecuted the identical statement:The
queryandqueryParamsare fully built before the branch, so the branching onChartRepoId/RegistryIdwas dead code. Collapsed the four identical branches into a single call.Why
Reported by the
revivelinter. Removes confusing dead branching with no behavior change.Fixes #6030