ci: verify all devcontainer features - #983
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec requirement
The devcontainer spec requires that a devcontainer's declared features are actually
installed and usable in the resulting container.
.devcontainer/devcontainer.jsondeclares four features whose purpose is to install specific binaries:
ghcr.io/skevetter/features/go-task:1taskghcr.io/skevetter/features/prek:1prekghcr.io/skevetter/features/uv:1uvghcr.io/devcontainers/features/node:2(v24)nodeThe devcontainer CI workflow (
.github/workflows/devcontainer.yml) builds thedevcontainer and runs a
runCmdsmoke-check to verify the image is usable.Gap found
The
runCmddefault only verified a single binary:So a devcontainer where
task,uv, ornodefailed to install would still pass theCI smoke-check, masking a spec-compliance gap: features are declared but their
installed binaries are not verified.
Change
Expand the
runCmddefault (and theDEFAULT_RUN_CMDenv that backs it fornon-dispatch runs) to verify all four feature-provided binaries are on
PATH:If any feature binary is missing, the check exits non-zero and prints
missing <bin>,so a broken feature install surfaces in CI instead of passing silently. The set of
checked binaries is exactly the set installed by the declared features.
Verification
task cli:format— passed (exit 0).task cli:lint:ci— passed, 0 new issues.task cli:test— passed except the known pre-existingpkg/gitfailures(
TestRepoCloneArgsThroughRunner,TestRepoCloneFromInfoBranch,TestRepoCloneFromInfoHelper) which fail onorigin/mainalready and are unrelatedto this change (this PR touches only
.github/workflows/devcontainer.yml)..github/workflows/devcontainer.ymlre-read end-to-end; YAML parses; therunCmdvalue is a single shell invocation consumed by
devcontainers/ci(the workflowresolves the dispatcher
runCmdinput with a fallback to theDEFAULT_RUN_CMDenv var), so the
for … doneloop executes correctly inside the built devcontainer..devcontainer/devcontainer-lock.jsonmatch the published feature image digests onghcr.io (no stale integrity).
task cli:test:e2e:suite -- "devcontainer"— not run in this sandbox (requiresDocker, unavailable here); the workflow itself is the devcontainer build/run gate.
This PR was created by an AI agent as part of an automated daily devcontainer spec job.