Skip to content

chore(deps): upgrade deps and tools - #905

Merged
skevetter merged 1 commit into
mainfrom
chore/update-deps
Aug 9, 2026
Merged

chore(deps): upgrade deps and tools#905
skevetter merged 1 commit into
mainfrom
chore/update-deps

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Signed-off-by: GitHub noreply@github.com

@netlify

netlify Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit c7f784b
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a78cad4fc183b00083d69de

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)
  • chore(deps)

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 54762138-01e5-4028-baad-1a06c48eb5ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit c7f784b
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a78cad469c8f900082fd16c

@github-actions github-actions Bot added the size/s label Aug 8, 2026
@skevetter
skevetter marked this pull request as ready for review August 8, 2026 15:55
@codacy-production

codacy-production Bot commented Aug 8, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While the PR successfully upgrades to Go 1.26.5 and adopts the modern tool directive for development dependencies, there are significant issues that should be addressed before merging.

The most critical concern is the presence of unaddressed high-severity vulnerabilities in docker/docker (CVE-2026-41567, CVE-2026-34040) and cel-go, despite this being a dependency upgrade chore. Additionally, the current implementation of the gRPC toolchain is likely to break; removing explicit go install commands for protoc plugins prevents them from being added to the system PATH, which protoc requires for execution. Finally, several tasks in Taskfile.yml still bypass the new version-pinning logic by using @latest or incorrect go get commands.

About this PR

  • The PR description is empty. Please provide context for the Go version upgrade and confirm if the migration to the Go 1.24 tool directive covers all intended development environments.

Test suggestions

  • Verify 'cli:build' tasks successfully execute using 'go tool goreleaser' with pinned versions.
  • Verify 'cli:test:e2e' tasks correctly invoke 'go tool ginkgo' and respect the version defined in go.mod.
  • Verify 'cli:build:grpc' correctly finds protoc plugins without manual install steps.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify 'cli:build' tasks successfully execute using 'go tool goreleaser' with pinned versions.
2. Verify 'cli:test:e2e' tasks correctly invoke 'go tool ginkgo' and respect the version defined in go.mod.
3. Verify 'cli:build:grpc' correctly finds protoc plugins without manual install steps.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread go.mod
Comment thread go.mod
Comment thread Taskfile.yml Outdated
Comment thread Taskfile.yml
devsy-app Bot pushed a commit that referenced this pull request Aug 9, 2026
Address review feedback on PR #905:

- cli:build:grpc: restore `go install` of protoc-gen-go and
  protoc-gen-go-grpc so protoc can locate the plugins in PATH.
  protoc invokes plugins via PATH, which `go tool` cannot satisfy.
- Remove the unused go:tools task whose `go get -u ./...` command
  updated module deps rather than installing tools.
- Drop the redundant cli:test:e2e:ginkgo:install dependency from the
  e2e tasks; `go tool ginkgo` runs the version-locked binary on demand.
- cli:test:e2e:ginkgo:install: drop `@latest` to avoid version drift,
  installing the version pinned by go.mod instead.
@devsy-app

devsy-app Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA.
Posted by the CLA Assistant Lite bot.

skevetter pushed a commit that referenced this pull request Aug 9, 2026
Address review feedback on PR #905:

- cli:build: switch to `go tool goreleaser` for version-locked builds
  (devsy, devsy-dev, devsy-pro-dev), removing the manual PATH workaround.
- cli:build:grpc: restore `go install` of protoc-gen-go and
  protoc-gen-go-grpc so protoc can locate the plugins in PATH.
  protoc invokes plugins via PATH, which `go tool` cannot satisfy.
- Remove the unused go:tools task whose `go get -u ./...` command
  updated module deps rather than installing tools.
- Drop the redundant cli:test:e2e:ginkgo:install dependency from the
  e2e tasks; `go tool ginkgo` runs the version-locked binary on demand.
- cli:test:e2e:ginkgo:install: drop `@latest` to avoid version drift,
  installing the version pinned by go.mod instead.
- go.mod/go.sum: upgrade module dependencies and tools.

Signed-off-by: GitHub <noreply@github.com>
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@skevetter skevetter closed this Aug 9, 2026
Address review feedback on PR #905:

- cli:build: switch to `go tool goreleaser` for version-locked builds
  (devsy, devsy-dev, devsy-pro-dev), removing the manual PATH workaround.
- cli:build:grpc: restore `go install` of protoc-gen-go and
  protoc-gen-go-grpc so protoc can locate the plugins in PATH.
  protoc invokes plugins via PATH, which `go tool` cannot satisfy.
- Remove the unused go:tools task whose `go get -u ./...` command
  updated module deps rather than installing tools.
- Drop the redundant cli:test:e2e:ginkgo:install dependency from the
  e2e tasks; `go tool ginkgo` runs the version-locked binary on demand.
- cli:test:e2e:ginkgo:install: drop `@latest` to avoid version drift,
  installing the version pinned by go.mod instead.
- go.mod/go.sum: upgrade module dependencies and tools.

Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions Bot added size/xs and removed size/s labels Aug 9, 2026
@skevetter skevetter reopened this Aug 9, 2026
@github-actions github-actions Bot added size/s and removed size/xs labels Aug 9, 2026
@skevetter
skevetter enabled auto-merge (squash) August 9, 2026 18:48
@skevetter
skevetter merged commit 1ee39d7 into main Aug 9, 2026
67 checks passed
@skevetter
skevetter deleted the chore/update-deps branch August 9, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant