chore(deps): upgrade deps and tools - #905
Conversation
✅ Deploy Preview for images-devsy-sh canceled.
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for devsydev canceled.
|
11fc800 to
1dd86bf
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
While the PR successfully upgrades to Go 1.26.5 and adopts the modern tool directive for development dependencies, there are significant issues that should be addressed before merging.
The most critical concern is the presence of unaddressed high-severity vulnerabilities in docker/docker (CVE-2026-41567, CVE-2026-34040) and cel-go, despite this being a dependency upgrade chore. Additionally, the current implementation of the gRPC toolchain is likely to break; removing explicit go install commands for protoc plugins prevents them from being added to the system PATH, which protoc requires for execution. Finally, several tasks in Taskfile.yml still bypass the new version-pinning logic by using @latest or incorrect go get commands.
About this PR
- The PR description is empty. Please provide context for the Go version upgrade and confirm if the migration to the Go 1.24 tool directive covers all intended development environments.
Test suggestions
- Verify 'cli:build' tasks successfully execute using 'go tool goreleaser' with pinned versions.
- Verify 'cli:test:e2e' tasks correctly invoke 'go tool ginkgo' and respect the version defined in go.mod.
- Verify 'cli:build:grpc' correctly finds protoc plugins without manual install steps.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify 'cli:build' tasks successfully execute using 'go tool goreleaser' with pinned versions.
2. Verify 'cli:test:e2e' tasks correctly invoke 'go tool ginkgo' and respect the version defined in go.mod.
3. Verify 'cli:build:grpc' correctly finds protoc plugins without manual install steps.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Address review feedback on PR #905: - cli:build:grpc: restore `go install` of protoc-gen-go and protoc-gen-go-grpc so protoc can locate the plugins in PATH. protoc invokes plugins via PATH, which `go tool` cannot satisfy. - Remove the unused go:tools task whose `go get -u ./...` command updated module deps rather than installing tools. - Drop the redundant cli:test:e2e:ginkgo:install dependency from the e2e tasks; `go tool ginkgo` runs the version-locked binary on demand. - cli:test:e2e:ginkgo:install: drop `@latest` to avoid version drift, installing the version pinned by go.mod instead.
|
All contributors have signed the CLA. |
Address review feedback on PR #905: - cli:build: switch to `go tool goreleaser` for version-locked builds (devsy, devsy-dev, devsy-pro-dev), removing the manual PATH workaround. - cli:build:grpc: restore `go install` of protoc-gen-go and protoc-gen-go-grpc so protoc can locate the plugins in PATH. protoc invokes plugins via PATH, which `go tool` cannot satisfy. - Remove the unused go:tools task whose `go get -u ./...` command updated module deps rather than installing tools. - Drop the redundant cli:test:e2e:ginkgo:install dependency from the e2e tasks; `go tool ginkgo` runs the version-locked binary on demand. - cli:test:e2e:ginkgo:install: drop `@latest` to avoid version drift, installing the version pinned by go.mod instead. - go.mod/go.sum: upgrade module dependencies and tools. Signed-off-by: GitHub <noreply@github.com>
2fc8274 to
74832a2
Compare
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
74832a2 to
9f37ddd
Compare
Address review feedback on PR #905: - cli:build: switch to `go tool goreleaser` for version-locked builds (devsy, devsy-dev, devsy-pro-dev), removing the manual PATH workaround. - cli:build:grpc: restore `go install` of protoc-gen-go and protoc-gen-go-grpc so protoc can locate the plugins in PATH. protoc invokes plugins via PATH, which `go tool` cannot satisfy. - Remove the unused go:tools task whose `go get -u ./...` command updated module deps rather than installing tools. - Drop the redundant cli:test:e2e:ginkgo:install dependency from the e2e tasks; `go tool ginkgo` runs the version-locked binary on demand. - cli:test:e2e:ginkgo:install: drop `@latest` to avoid version drift, installing the version pinned by go.mod instead. - go.mod/go.sum: upgrade module dependencies and tools. Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub noreply@github.com