You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(wslg): name the reason a discovery probe failed - #1886
No actionable comments were generated in the recent review.
Walkthrough
WSLg probe execution now reports output-limit failures separately from other command failures. Protocol errors include details about exit status, output sizes, or malformed values. Tests cover oversized stdout and stderr and check that errors omit private output.
Changes: WSLg probe error reporting
Layer / File(s)
Summary
Probe error classification and diagnostics pkg/wslg/command.go, pkg/wslg/wslg.go, pkg/wslg/wslg_test.go
Probe execution distinguishes output-limit failures from other command failures. Protocol errors include reasons for unexpected exit status, oversized output, invalid UTF-8, missing trailing newline, or control characters. Tests cover both output streams and verify that errors omit private output.
devsy-org/devsy#1503: Adds the WSLg display discovery code that this PR updates.
Merge Risk: Minimal · up to 3b577
This change makes WSLg discovery probe failures more descriptive without exposing captured subprocess output. No concrete merge-blocking risk was found, and the change is easy to revert.
Pre-merge checks: 3 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Description check
The author did not write a pull request description. The body only contains a quoted notice that no description was added, so none of the template sections (what and why, linked issue, type of change,…
Add a pull request description that follows the repository template. Include: a Conventional Commits title; a What and why section that starts with the problem (WSLg probe failures did not name the reason, and output-limit errors were not d…
Passed checks: 3 passed
Check name
Status
Explanation
Title check
The title names the main change: WSLg discovery probe failures now report the specific reason. It follows the Conventional Commits form with the fix(wslg) scope. The changeset matches it: output-limit…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: WSLg discovery probe failures now report the specific reason. It follows the Conventional Commits form with the fix(wslg) scope. The changeset matches it: output-limit errors are separated from other failures, and protocol errors carry specific reasons.
Full details: Description check
Explanation
The author did not write a pull request description. The body only contains a quoted notice that no description was added, so none of the template sections (what and why, linked issue, type of change, AI assistance disclosure, testing, checklist, reviewer notes) are filled in. The PR objectives describe the intent, but the author's own description does not state it, and the template requires the author to provide it.
Resolution
Add a pull request description that follows the repository template. Include: a Conventional Commits title; a What and why section that starts with the problem (WSLg probe failures did not name the reason, and output-limit errors were not distinguished); a Fixes or Refs line for the related issue, or 'none'; the Type of change (likely Bug fix); the AI assistance disclosure; the Testing section with the unit test commands run (for example, go test -race -count=1 -v ./pkg/wslg on macOS and the Windows cross-compile) and a note on the native WSLg test not being run; and the Checklist items with their status. Delete any template sections that do not apply and leave no placeholders.
Finishing Touches
Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 5ae41142-d7a6-42ce-8b89-6590784765c5
Commits
Reviewing files that changed from the base of the PR and between 83d86d1 and 3b57762.
Files selected for processing: 3
pkg/wslg/command.go
pkg/wslg/wslg.go
pkg/wslg/wslg_test.go
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
Independent Oh My Pi Sol 6.2 review of 3b577627: no blocking findings. Capture reports the output limit without exposing either stream and preserves protocol error classification, cancellation precedence, and quiet exit-1 handling. Both subprocess overflow regressions, the native WSLg probe, and Compose parity passed on hosted Windows. CI Success and Check Commits passed on this exact head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.