test(e2e): widen podman rootless-config spec timeouts - #1091
Open
devsy-app[bot] wants to merge 1 commit into
Open
test(e2e): widen podman rootless-config spec timeouts#1091devsy-app[bot] wants to merge 1 commit into
devsy-app[bot] wants to merge 1 commit into
Conversation
bump up-provider-podman-rootless-config suite SpecTimeout from TimeoutShort (3m) to TimeoutModerate (5m); rootless podman agent injection retries were exhausting the 3m budget (CI run 32006664625 timed out mid-DevsySSH)
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 4 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
skevetter
marked this pull request as ready for review
August 17, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
up-provider-podman-rootless-confige2e suite was flaky/timing out onmain. This bumps the per-spec timeout for all 5 specs in that suite fromTimeoutShort(3 min) toTimeoutModerate(5 min) to give rootless-podman container creation + agent injection enough headroom.Logs inspected
32006664625(main branch, ubuntu-latest, jobup-provider-podman-rootless-config (rootless))should merge extra devcontainer configreportedbase_value [TIMEDOUT]ate2e/tests/up/provider_podman_rootless_config.go:156, then the suite panicked withtest timed out after 10m0s.retrying injection: [version check] get remote agent version timed out: run command in container: context deadline exceeded: signal: killed. Under runner load, rootless-podman agent injection retries consumed the 3-minute spec budget, so the spec's ginkgoSpecTimeout(TimeoutShort)fired mid-DevsySSH.Root cause
Every spec in the
configurationcontext ofprovider_podman_rootless_config.goperforms a fullDevsyUp(container creation + devsy-agent injection) plus multipleDevsySSHcalls and aDevsyWorkspaceDelete. The slow, retry-prone rootless-podman agent injection makes the 3-minTimeoutShortbudget too tight. The sibling suiteprovider_podman_rootless_basic.goalready usesTimeoutLong(10 min) for comparableDevsyUp+DevsySSHwork (e.g. the nonroot-user spec), confirming the 3-min budget here is the outlier.Change
e2e/tests/up/provider_podman_rootless_config.go: bump all 5ginkgo.SpecTimeout(framework.TimeoutShort())toginkgo.SpecTimeout(framework.TimeoutModerate()).TimeoutModerate(5 min) gives 2 extra minutes of headroom over the 3-min budget that demonstrably timed out, while staying tighter thanTimeoutLong.Verification
go build ./e2e/...— compiles (exit 0)task cli:format— clean (no changes beyond intent)task cli:lint:ci— 0 new issuestask cli:test— no NEW failures. Pre-existing failures onorigin/main(verified by stashing this change and re-running):pkg/gitTestRepoClone*— documented stale assertion (known pre-existing)pkg/dockerTestRunCmd_CancelKillsProcessGroup— environment/sandbox process-group issue, fails on cleanmaintooe2e/tests/up/provider_podman_rootless_config.goand introduces no new lint issues or test failures.The focused e2e suite (
up-provider-podman-rootless-config) requires a podman/docker runtime, which is unavailable in this sandbox; the e2e test binary builds cleanly.This PR was created by an AI agent as part of an automated daily e2e review job.