Skip to content

test(e2e): widen podman rootless-config spec timeouts - #1091

Open
devsy-app[bot] wants to merge 1 commit into
mainfrom
integration-test/podman-rootless-config-timeout
Open

test(e2e): widen podman rootless-config spec timeouts#1091
devsy-app[bot] wants to merge 1 commit into
mainfrom
integration-test/podman-rootless-config-timeout

Conversation

@devsy-app

@devsy-app devsy-app Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

The up-provider-podman-rootless-config e2e suite was flaky/timing out on main. This bumps the per-spec timeout for all 5 specs in that suite from TimeoutShort (3 min) to TimeoutModerate (5 min) to give rootless-podman container creation + agent injection enough headroom.

Logs inspected

  • CI run: 32006664625 (main branch, ubuntu-latest, job up-provider-podman-rootless-config (rootless))
  • Failure: the spec should merge extra devcontainer config reported base_value [TIMEDOUT] at e2e/tests/up/provider_podman_rootless_config.go:156, then the suite panicked with test timed out after 10m0s.
  • Root cause in logs: repeated retrying injection: [version check] get remote agent version timed out: run command in container: context deadline exceeded: signal: killed. Under runner load, rootless-podman agent injection retries consumed the 3-minute spec budget, so the spec's ginkgo SpecTimeout(TimeoutShort) fired mid-DevsySSH.

Root cause

Every spec in the configuration context of provider_podman_rootless_config.go performs a full DevsyUp (container creation + devsy-agent injection) plus multiple DevsySSH calls and a DevsyWorkspaceDelete. The slow, retry-prone rootless-podman agent injection makes the 3-min TimeoutShort budget too tight. The sibling suite provider_podman_rootless_basic.go already uses TimeoutLong (10 min) for comparable DevsyUp+DevsySSH work (e.g. the nonroot-user spec), confirming the 3-min budget here is the outlier.

Change

  • e2e/tests/up/provider_podman_rootless_config.go: bump all 5 ginkgo.SpecTimeout(framework.TimeoutShort()) to ginkgo.SpecTimeout(framework.TimeoutModerate()).
  • No behavioral change; only the per-spec deadline is widened. TimeoutModerate (5 min) gives 2 extra minutes of headroom over the 3-min budget that demonstrably timed out, while staying tighter than TimeoutLong.

Verification

  • go build ./e2e/... — compiles (exit 0)
  • task cli:format — clean (no changes beyond intent)
  • task cli:lint:ci — 0 new issues
  • task cli:test — no NEW failures. Pre-existing failures on origin/main (verified by stashing this change and re-running):
    • pkg/git TestRepoClone* — documented stale assertion (known pre-existing)
    • pkg/docker TestRunCmd_CancelKillsProcessGroup — environment/sandbox process-group issue, fails on clean main too
  • My change only touches e2e/tests/up/provider_podman_rootless_config.go and introduces no new lint issues or test failures.

The focused e2e suite (up-provider-podman-rootless-config) requires a podman/docker runtime, which is unavailable in this sandbox; the e2e test binary builds cleanly.

This PR was created by an AI agent as part of an automated daily e2e review job.

bump up-provider-podman-rootless-config suite SpecTimeout from TimeoutShort (3m) to TimeoutModerate (5m); rootless podman agent injection retries were exhausting the 3m budget (CI run 32006664625 timed out mid-DevsySSH)
@netlify

netlify Bot commented Aug 17, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit f5937c8
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a82fe7114eb4300082d3b7e

@netlify

netlify Bot commented Aug 17, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit f5937c8
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a82fe736e70bf0008ba7103

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 4 duplication

Metric Results
Complexity 0
Duplication 4

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@skevetter
skevetter marked this pull request as ready for review August 17, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants