Split up-provider-podman-rootless-basic e2e test - #1084
Conversation
✅ Deploy Preview for images-devsy-sh canceled.
|
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 4 critical |
🟢 Metrics 10 complexity · 7 duplication
Metric Results Complexity 10 Duplication 7
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Move agent-delivery/exec/cleanup specs into a new up-provider-podman-rootless-exec CI job so each job finishes well within the 10m go test timeout.
439fc32 to
b614095
Compare
Summary
Two e2e jobs were timing out at the 10 minute go test timeout. Splits their ginkgo specs across additional CI jobs so each completes comfortably within the timeout.
up-provider-podman-rootless-basic
e2e/tests/up/provider_podman_rootless_basic.go: keepsbasic+buildcontexts, label unchanged (up-provider-podman-rootless-basic).e2e/tests/up/provider_podman_rootless_exec.go(new): movedagent delivery+exec+cleanupcontexts here, new labelup-provider-podman-rootless-exec.up-provider-podman-rootful-lifecycle
e2e/tests/up/provider_podman_rootful_lifecycle.go: keeps the postCreateCommand/postStartCommand/waitFor/postAttach-blocking specs, label unchanged (up-provider-podman-rootful-lifecycle).e2e/tests/up/provider_podman_rootful_lifecycle_2.go(new): moved the postAttachCommand-every-attach/initializeCommand/secrets-file specs here, new labelup-provider-podman-rootful-lifecycle-2.CI
.github/workflows/pr-ci.yml: added matching matrix entries forup-provider-podman-rootless-execandup-provider-podman-rootful-lifecycle-2(same runner/podman/timeout/flake settings as their sibling jobs).