Skip to content

Split up-provider-podman-rootless-basic e2e test - #1084

Merged
skevetter merged 1 commit into
mainfrom
split-podman-rootless-basic-e2e-test
Aug 17, 2026
Merged

Split up-provider-podman-rootless-basic e2e test#1084
skevetter merged 1 commit into
mainfrom
split-podman-rootless-basic-e2e-test

Conversation

@skevetter

@skevetter skevetter commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Two e2e jobs were timing out at the 10 minute go test timeout. Splits their ginkgo specs across additional CI jobs so each completes comfortably within the timeout.

up-provider-podman-rootless-basic

  • e2e/tests/up/provider_podman_rootless_basic.go: keeps basic + build contexts, label unchanged (up-provider-podman-rootless-basic).
  • e2e/tests/up/provider_podman_rootless_exec.go (new): moved agent delivery + exec + cleanup contexts here, new label up-provider-podman-rootless-exec.

up-provider-podman-rootful-lifecycle

  • e2e/tests/up/provider_podman_rootful_lifecycle.go: keeps the postCreateCommand/postStartCommand/waitFor/postAttach-blocking specs, label unchanged (up-provider-podman-rootful-lifecycle).
  • e2e/tests/up/provider_podman_rootful_lifecycle_2.go (new): moved the postAttachCommand-every-attach/initializeCommand/secrets-file specs here, new label up-provider-podman-rootful-lifecycle-2.

CI

.github/workflows/pr-ci.yml: added matching matrix entries for up-provider-podman-rootless-exec and up-provider-podman-rootful-lifecycle-2 (same runner/podman/timeout/flake settings as their sibling jobs).

@netlify

netlify Bot commented Aug 17, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit b614095
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a8339f086e0da000858a739

@netlify

netlify Bot commented Aug 17, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit b614095
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a8339f00ade700008ff05e0

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ab26e27-5562-4ed9-bcda-674556ff1b5f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

codacy-production Bot commented Aug 17, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 4 critical

Alerts:
⚠ 4 issues (≤ 0 issues of at least minor severity)

Results:
4 new issues

Category Results
Security 4 critical

View in Codacy

🟢 Metrics 10 complexity · 7 duplication

Metric Results
Complexity 10
Duplication 7

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Move agent-delivery/exec/cleanup specs into a new
up-provider-podman-rootless-exec CI job so each job finishes well
within the 10m go test timeout.
@skevetter
skevetter force-pushed the split-podman-rootless-basic-e2e-test branch from 439fc32 to b614095 Compare August 17, 2026 16:42
@skevetter
skevetter marked this pull request as ready for review August 17, 2026 17:27
@skevetter
skevetter merged commit e0813be into main Aug 17, 2026
78 checks passed
@skevetter
skevetter deleted the split-podman-rootless-basic-e2e-test branch August 17, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant