test(command): cover Quote escape behavior - #1072
Open
devsy-app[bot] wants to merge 3 commits into
Open
Conversation
Add table-driven test for pkg/command Quote covering empty, single-arg passthrough, multi-arg join, and special-char escaping.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Signed-off-by: Samuel K <skevetter@pm.me>
skevetter
marked this pull request as ready for review
August 17, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package reviewed
pkg/command— theQuotehelper inpkg/command/escape.go.Issue found
Quotehad no dedicated test coverage. Its behavior is non-obvious and easy to regress:nil/empty input → returns""["agent internal ssh-git-clone"]→agent internal ssh-git-cloneshellescape.QuoteCommand(with embedded single-quote escaping)This helper is security-adjacent: it is used in
pkg/agent/workspace.goto build theGIT_SSH_COMMANDstring passed to the shell, so a regression in its escaping could break quoting of paths/keys containing spaces or special characters.Change
Add
pkg/command/escape_test.go— a table-driven test (TestQuote) that locks in all three branches plus the tricky embedded-single-quote escaping case:niland[]string{})'→'"'"')No behavior change — pure test addition.
Verification performed
task cli:format— cleantask cli:lint:ci— 0 issuestask cli:test—pkg/commandpasses; the only failure is the known pre-existingpkg/gitTestRepoClone*stale-assertion failure (untouched by this change)go test ./pkg/command/ -run TestQuote -v— all subtests PASSCommit
be4a99dis app-signed (verified=true).This PR was created by an AI agent as part of an automated daily package review job.