Skip to content

fix(cmd): lowercase credentials server logs #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Aug 18, 2026
Merged

fix(cmd): lowercase credentials server logs #1071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6aede5
fix(cmd): lowercase credentials server logs
devsy-app[bot] Aug 16, 2026
e55563a
Merge branch 'main' into cmd-reviewer/lowercase-credentials-server-logs
skevetter Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cmd/internal/agentcontainer/credentials_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,13 +200,13 @@ func (cmd *CredentialsServerCmd) configureGitSigningKey() func() {

decodedKey, err := base64.StdEncoding.DecodeString(cmd.GitUserSigningKey)
if err != nil {
log.Errorf("Failed to decode git SSH signing key, signing will be unavailable: %v", err)
log.Errorf("failed to decode git SSH signing key, signing will be unavailable: %v", err)
return noop
}

if err := gitsshsigning.ConfigureHelper(cmd.User, string(decodedKey)); err != nil {
log.Errorf(
"Failed to configure git SSH signature helper, signing will be unavailable: %v",
"failed to configure git SSH signature helper, signing will be unavailable: %v",
err,
)
return noop
Expand Down Expand Up @@ -279,12 +279,12 @@ func forwardPorts(ctx context.Context, client tunnel.TunnelClient) error {
func portOptionsFromResult() []netstat.WatcherOption {
raw, err := os.ReadFile(config.DevContainerResultPath)
if err != nil {
log.Debugf("Could not read result for port attributes: %v", err)
log.Debugf("could not read result for port attributes: %v", err)
return nil
}
result := &devconfig.Result{}
if err := json.Unmarshal(raw, result); err != nil {
log.Debugf("Could not parse result for port attributes: %v", err)
log.Debugf("could not parse result for port attributes: %v", err)
return nil
}
mc := result.MergedConfig
Expand Down Expand Up @@ -320,7 +320,7 @@ type forwarder struct {
// Forward relays the auto-discovered port to the client over gRPC.
func (f *forwarder) Forward(port string, attr netstat.PortForwardAttribute) error {
if attr.Label != "" {
log.Debugf("Forwarding port %s (%s, protocol=%s)", port, attr.Label, attr.Protocol)
log.Debugf("forwarding port %s (%s, protocol=%s)", port, attr.Label, attr.Protocol)
}
_, err := f.client.ForwardPort(f.ctx, &tunnel.ForwardPortRequest{Port: port})
return err
Expand Down
Loading