You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Codefactor message: Exported function ClassifyVersionSource returns unexported type sourceKind, making the return value unusable by external callers of the public API.
Change
Export the sourceKind type and its constants so ClassifyVersionSource's public signature is usable by external callers:
sourceKind → SourceKind
sourceUnknown → SourceUnknown
sourceGitHub → SourceGitHub
sourceManifestURL → SourceManifestURL
sourceLocal → SourceLocal
The internal call site in ListVersionsForSource and the table-driven test in versions_test.go were updated to the exported names. No behavior change.
Verification
task cli:format — clean
task cli:lint:ci — 0 issues
task cli:test — pkg/provider passes. (Pre-existing known failure pkg/gitTestRepoClone* fails on origin/main already; this change does not touch pkg/git.)
This PR was created by an AI agent as part of an automated daily Codefactor issue fix job.
ClassifyVersionSource is an exported function but returned the unexported sourceKind type (and its unexported constants), flagged by Codefactor (Maintainability: exported func returning unexported type). Export the type and constants as SourceKind/SourceUnknown/SourceGitHub/SourceManifestURL/SourceLocal so the API is usable by external callers. No behavior change; tests updated to the exported names.
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codefactor fix: exported func returns unexported type
6a77b13d5b1ec0b4ee20c45e(Maintainability, Minor)pkg/provider/versions.go:30ClassifyVersionSourcereturns unexported typesourceKind, making the return value unusable by external callers of the public API.Change
Export the
sourceKindtype and its constants soClassifyVersionSource's public signature is usable by external callers:sourceKind→SourceKindsourceUnknown→SourceUnknownsourceGitHub→SourceGitHubsourceManifestURL→SourceManifestURLsourceLocal→SourceLocalThe internal call site in
ListVersionsForSourceand the table-driven test inversions_test.gowere updated to the exported names. No behavior change.Verification
task cli:format— cleantask cli:lint:ci— 0 issuestask cli:test—pkg/providerpasses. (Pre-existing known failurepkg/gitTestRepoClone*fails onorigin/mainalready; this change does not touchpkg/git.)This PR was created by an AI agent as part of an automated daily Codefactor issue fix job.