Skip to content

fix(port): bracket IPv6 hosts in tcp address #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devsy-app wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −2
Open

fix(port): bracket IPv6 hosts in tcp address #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b23028
fix(port): bracket IPv6 hosts in tcp address
devsy-app[bot] Aug 15, 2026
582a5a7
style: update comments
skevetter Aug 17, 2026
1973331
Merge branch 'main' into pkg-tunnel-network/ipv6-joinhostport
skevetter Aug 17, 2026
0359c52
style: apply formatting
skevetter Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/port/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package port

import (
"fmt"
"net"
"strconv"
"strings"
)
Expand Down Expand Up @@ -36,7 +37,7 @@ func toAddress(host, port string) (Address, error) {

return Address{
Protocol: "tcp",
Address: host + ":" + port,
Address: net.JoinHostPort(host, port),
}, nil
}

Expand Down
8 changes: 7 additions & 1 deletion pkg/port/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,13 @@ func TestToAddress_TCP(t *testing.T) {
Address{Protocol: protoTCP, Address: "database.internal:5432"},
},
{"short hostname", "db", "5432", Address{Protocol: protoTCP, Address: "db:5432"}},
{"IPv6 address", "::1", "8080", Address{Protocol: protoTCP, Address: "::1:8080"}},
{"IPv6 address", "::1", "8080", Address{Protocol: protoTCP, Address: "[::1]:8080"}},
{
"IPv6 host brackets for listen",
"fe80::1",
"443",
Address{Protocol: protoTCP, Address: "[fe80::1]:443"},
},
}

for _, tt := range tests {
Expand Down
Loading