ci: add timeout-minutes to desktop-ci jobs - #1054
Draft
devsy-app[bot] wants to merge 1 commit into
Draft
Conversation
Add timeout-minutes to the lint-and-test (15), build-desktop (45), and build-flatpak (30) jobs in desktop-ci.yml. These long-running build jobs previously had no timeout, so a hung job (playwright browser stall, electron-builder hang, flatpak build stall) would burn the 6h default. Values match the existing pr-ci.yml 45-min convention.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs inspected
Recent
desktop-ci.ymlruns ondevsy-org/devsy(viagh run list):build-desktop(ubuntu/macos matrix): ~10-12 minbuild-flatpak: ~7 minlint-and-test: ~1 minNone of these jobs had a
timeout-minutesset, so each inherited GitHub Actions 6-hour default.Problem found
The
desktop-ci.ymljobs (lint-and-test,build-desktop,build-flatpak) had notimeout-minutes, leaving them exposed to the 6-hour default. A hung job (a Playwright browser stall, an electron-builder freeze, or a flatpak build stall) would burn the full 6h of CI minutes before being killed.Minimal change
Added
timeout-minutesto the three jobs in.github/workflows/desktop-ci.yml:lint-and-test:15build-desktop:45build-flatpak:30Values are based on observed run durations with headroom and match the existing convention in
pr-ci.yml(timeout-minutes: 45). Single file, 3 added lines, no behavioral change beyond the timeout guard.Validation performed
python3 -c "import yaml; yaml.safe_load(...)"->YAML OKact --list -W .github/workflows/desktop-ci.yml-> enumerated all 4 jobs (changes,lint-and-test,build-desktop,build-flatpak) successfullypkg/git(TestRepoClone*) failure remains, which is unrelated to this YAML-only change (known stale assertion on origin/main)This PR was created by an AI agent as part of an automated daily CI optimization job.