fix(dockerfile): guard nil deref in parseUser/parseArg - #1044
Merged
Conversation
guard against nil Next in parseUser/parseArg
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Signed-off-by: Samuel K <skevetter@pm.me>
skevetter
marked this pull request as ready for review
August 17, 2026 05:57
skevetter
enabled auto-merge (squash)
August 18, 2026 06:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package reviewed
pkg/dockerfileIssue found
parseUserandparseArgdereferencedinstruction.Nextwithout a nil check. When a Dockerfile contains a bare directive with no value (e.g.FROM ubuntufollowed by a malformedUSERorARGwith no argument), the buildkit parser still emits the directive node withNext == nil, causingParseto panic with a nil-pointer dereference instead of returning a parsed (valueless) entry. This crashes any caller that parses untrusted/malformed Dockerfile content.Change
Guard the
instruction.Nextaccess inparseUserandparseArgand return an empty key-value pair when the directive carries no value (mirroring the nil-safe patterns already used byparseEnvandparseStage). Two tests were added toparse_test.gocovering theUSER-with-no-value andARG-with-no-value cases, confirming the parser no longer panics.pkg/dockerfile/parse.go: nil-guard added toparseUserandparseArg.pkg/dockerfile/parse_test.go:TestValuelessUserDoesNotPanic,TestValuelessArgDoesNotPanic.Verification performed
task cli:format— clean (no formatting changes to touched files).task cli:lint:ci— 0 issues.task cli:test—pkg/dockerfilepasses (all tests including the two new ones). The only failing package ispkg/git(TestRepoClone*), a known pre-existing failure onorigin/mainunrelated to this change (nopkg/gitfiles touched).This PR was created by an AI agent as part of an automated daily package review job.