Skip to content

ci: verify go toolchain in devcontainer runCmd - #1016

Merged
skevetter merged 1 commit into
mainfrom
devcontainer-spec/verify-go-runcmd
Aug 13, 2026
Merged

ci: verify go toolchain in devcontainer runCmd#1016
skevetter merged 1 commit into
mainfrom
devcontainer-spec/verify-go-runcmd

Conversation

@devsy-app

@devsy-app devsy-app Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Spec requirement

The devcontainer declares the Go toolchain as its base image
(.devcontainer/devcontainer.json -> "image": "mcr.microsoft.com/devcontainers/go:1.26"),
and the repo is a Go CLI. The devcontainer CI workflow's runCmd verification command is
the spec gate that asserts the declared toolchain is actually present inside the built
container -- but it only checked task prek uv node, omitting go.

Gap found

.github/workflows/devcontainer.yml -- the workflow_dispatch input default and the
DEFAULT_RUN_CMD env both verified the devcontainer-provided tools, but never verified
go itself. A devcontainer build that silently dropped the Go toolchain (e.g. a base-image
regression or a feature override) would pass CI despite breaking the repo's primary build.

Change

Add go to the runCmd verification list in both the workflow_dispatch input default and
the DEFAULT_RUN_CMD env, so the devcontainer CI now asserts the declared Go toolchain is
present:

-default: for c in task prek uv node; do ...
+default: for c in go task prek uv node; do ...

Minimal, one file, two lines.

Verification

  • python3 -c "import yaml; yaml.safe_load(open('.github/workflows/devcontainer.yml'))" -> YAML OK
  • task cli:format -> clean (no changes)
  • task cli:lint:ci -> 0 issues. (0 new issues)
  • task cli:test -> only the known pre-existing failures fail
    (pkg/git TestRepoClone*, and e2e TestRunE2ETests which requires external resources);
    both reproduce identically on clean origin/main (verified via git stash baseline) and
    are unrelated to this YAML-only change.
  • devcontainer build lock regeneration: not needed -- no features changed, lock file untouched.

This PR was created by an AI agent as part of an automated daily devcontainer spec job.

Add go to the devcontainer CI runCmd verification list.
@netlify

netlify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit ed78e27
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a7c6814b438fd00085d0a7e

@netlify

netlify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit ed78e27
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a7c6814b438fd00085d0a84

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@skevetter
skevetter marked this pull request as ready for review August 13, 2026 13:34
@skevetter
skevetter merged commit d0cc4ea into main Aug 13, 2026
27 checks passed
@skevetter
skevetter deleted the devcontainer-spec/verify-go-runcmd branch August 13, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant