ci: verify go toolchain in devcontainer runCmd - #1016
Merged
Conversation
Add go to the devcontainer CI runCmd verification list.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec requirement
The devcontainer declares the Go toolchain as its base image
(
.devcontainer/devcontainer.json->"image": "mcr.microsoft.com/devcontainers/go:1.26"),and the repo is a Go CLI. The devcontainer CI workflow's
runCmdverification command isthe spec gate that asserts the declared toolchain is actually present inside the built
container -- but it only checked
task prek uv node, omittinggo.Gap found
.github/workflows/devcontainer.yml-- theworkflow_dispatchinput default and theDEFAULT_RUN_CMDenv both verified the devcontainer-provided tools, but never verifiedgoitself. A devcontainer build that silently dropped the Go toolchain (e.g. a base-imageregression or a feature override) would pass CI despite breaking the repo's primary build.
Change
Add
goto the runCmd verification list in both theworkflow_dispatchinput default andthe
DEFAULT_RUN_CMDenv, so the devcontainer CI now asserts the declared Go toolchain ispresent:
Minimal, one file, two lines.
Verification
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/devcontainer.yml'))"-> YAML OKtask cli:format-> clean (no changes)task cli:lint:ci->0 issues.(0 new issues)task cli:test-> only the known pre-existing failures fail(
pkg/gitTestRepoClone*, ande2eTestRunE2ETests which requires external resources);both reproduce identically on clean
origin/main(verified viagit stashbaseline) andare unrelated to this YAML-only change.
devcontainer buildlock regeneration: not needed -- no features changed, lock file untouched.This PR was created by an AI agent as part of an automated daily devcontainer spec job.