Repository navigation
test: stress supervisor-owned runtime streams - #17
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owned supervisor has process-cleanup coverage, but its real gRPC transport has not been stressed with large duplex streams. Add an internal fixture and supervisor-backed probes that transfer 100 MiB of stdin and verify 100 MiB on both stdout and stderr, distinct binary tails, and exactly one terminal exit.
The probes exercise paced host/plugin consumers, paused input and output backpressure, cancellation, synthetic command early exit, and an actual plugin process crash while stdin is active. Sender readiness is acknowledged, and sender termination is checked before cleanup can mask an early-exit/crash hang. Incremental hashes keep the test payload out of retained memory. A separate control stream measures live Go heap after GC while data is paused, enforces a 32 MiB growth budget over the connected baseline, and verifies the transport remains usable after cancellation.
This is transport evidence, not a peak-RSS bound or certification of a real runtime's process/environment behavior. Runtime executable paths include spaces and Unicode. The existing Linux/macOS/Windows race-test jobs and runtime-tests artifacts already include the new probes; no workflow or protocol changes are needed. Real-runtime compatibility and supervisor startup measurements remain separate follow-ups.
Validation: