feat: add activties.yaml #56
Conversation
…ecause the old still exists
vbakke
left a comment
vbakke
left a comment
There was a problem hiding this comment.
Great! Let's discuss this in the meeting coming up 🙂
| docker cp yaml:/var/www/html/src/assets/YAML/generated/generated.yaml src/assets/YAML/generated/generated.yaml | ||
| # Commit all changed files back to the repository | ||
| - uses: planetscale/ghcommit-action@v0.1.6 | ||
| docker cp yaml:/var/www/html/src/assets/YAML/generated/generated.yaml src/assets/YAML/generated/generated.yaml # TODO: Remove |
There was a problem hiding this comment.
Ref the discussion we had regarding having the generated and input source files in the same folder, @wurstbrot:
What about keeping the source yaml files as they are, and move generated folder to root? Then it is not under src and will be obvious for anyone downloading the project.
/
- src/assets/YAML/**
- generated/
- activities.yaml
- dependency-tree.md
- scripts/
- generateDimensions.php
- ...
(And we don't need to rename /yaml-generation to /scripts, btw. It's just a suggestion to make things more self explanatory. But it will have a side-effect on trigering the php file.)
|
|
||
|
|
||
| // Store generated data | ||
| // Store generated data with meta document first |
There was a problem hiding this comment.
Great! 🙂
I'll copy this in DSOMM app👍
Removed unused team and evidence references. Not part of the the new v4 `activities.yaml`
|
|
||
| $errorMsg = array(); | ||
| $implementationReferenceFile = "src/assets/YAML/default/implementations.yaml"; | ||
| $metadata = readYaml("src/assets/YAML/meta.yaml"); |
There was a problem hiding this comment.
Ah, I just saw your comment about compatibility, @wurstbrot. We still need these lines to be compatible with generated.yaml. But they can be removed for activities.yaml.
feat: add activties.yaml with new breaking format, not breaking now because the old still exists
After yaml-generation run, the
activties.yamlhas the new header whilegenerated.yamlis as it was (for compability)