Security: Use of document.write in browser-sync.js#253
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The browser-sync.js file uses document.write() to inject a script tag. document.write is dangerous as it can overwrite the entire document if called after the document has finished loading, and it is a known vector for XSS attacks. Additionally, the script source is hardcoded to a local browser-sync endpoint. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
@tomaioo is attempting to deploy a commit to the sneakyhead's projects Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@tomaioo GREAT STUFF! Also need to check out your other PR #252. Thanks SOO MUCH! P.S. Check your notifications for team add 😎 May need your help on a few other things as we spin this project up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Use of document.write in browser-sync.js
Problem
Severity:
Medium| File:browser-sync.js:L10The browser-sync.js file uses document.write() to inject a script tag. document.write is dangerous as it can overwrite the entire document if called after the document has finished loading, and it is a known vector for XSS attacks. Additionally, the script source is hardcoded to a local browser-sync endpoint.
Solution
Replace document.write with safer DOM manipulation methods like document.createElement('script') and document.head.appendChild(). Consider removing this file from production builds entirely as browser-sync is a development tool.
Changes
browser-sync.js(modified)