Skip to content

#2726: Remove Docker edition fallback on Linux - #2776

Open
Hiepiscus wants to merge 1 commit into
devonfw:mainfrom
Hiepiscus:2726-docker-desktop-installation-fails-on-linux
Open

Hiepiscus wants to merge 1 commit into
devonfw:mainfrom
Hiepiscus:2726-docker-desktop-installation-fails-on-linux

Conversation

@Hiepiscus

@Hiepiscus Hiepiscus commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes #2726

Implemented changes:

  • Remove adjustRequestedEdition to avoid the misleading message.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

On Ubuntu, although WSL works too.

  1. Set the DOCKER_EDITION to docker with ide set-edtion docker docker
  2. Run ide docker or ide install docker
  3. verify that this output does not show again:
    Docker Desktop is not yet supported by IDEasy on Linux, installing Rancher Desktop instead.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat).
    If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed,
    you have updated our LICENSE.adoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Oct 30, 2026
@Hiepiscus Hiepiscus added docker docker and esp. DockerDesktop linux specific for linux OS (debian, ubunutu, suse, etc.) labels Oct 30, 2026
@coveralls

coveralls commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 41042096675

Coverage increased (+0.04%) to 75.328%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 21 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

21 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/docker/Docker.java 21 48.89%

Coverage Stats

Coverage Status
Relevant Lines: 19903
Covered Lines: 15645
Line Coverage: 78.61%
Relevant Branches: 8846
Covered Branches: 6011
Branch Coverage: 67.95%
Branches in Coverage %: Yes
Coverage Strength: 3.38 hits per line

💛 - Coveralls

@Hiepiscus
Hiepiscus force-pushed the 2726-docker-desktop-installation-fails-on-linux branch from fef74d2 to e3fa311 Compare October 30, 2026 10:37
@Hiepiscus Hiepiscus changed the title #2726: remove Docker edition fallback on Linux #2726: Remove Docker edition fallback on Linux Oct 30, 2026
@Hiepiscus Hiepiscus moved this from 🆕 New to Team Review in IDEasy board Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker docker and esp. DockerDesktop linux specific for linux OS (debian, ubunutu, suse, etc.)

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Docker Desktop installation fails on Linux

2 participants