Repository navigation
#2718: do not log variable values at trace level - #2739
Open
Ali-Shariati-Najafabadi wants to merge 4 commits into
Open
Ali-Shariati-Najafabadi wants to merge 4 commits into
Ali-Shariati-Najafabadi wants to merge 4 commits into
Conversation
Collaborator
Coverage Report for CI Build 41042797231Coverage increased (+0.02%) to 75.309%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions3 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
Ali-Shariati-Najafabadi
marked this pull request as ready for review
October 23, 2026 11:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2718
EnvironmentVariablesMap.getFlatloggedVariable NAME=valueat trace level for every variable it read, so secrets fromconf/ide.propertiesended up in the trace log. The trace messages no longer contain the value.Implemented changes:
EnvironmentVariablesMap.getFlatlogsVariable «name» is defined.instead of name and valuetestAlreadyDefinedSecretIsNotLoggedInLogOutputinEnvironmentVariablesTest(it was disabled until this issue is fixed)CHANGELOG.adocTesting instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
clirunmvn -Dtest=EnvironmentVariablesTest test.testAlreadyDefinedSecretIsNotLoggedInLogOutputfails without the change and passes with it.MY_TOKEN=secret-valuetoconf/ide.propertiesof a project and runide --trace env.Variable MY_TOKEN=secret-value. TheMY_TOKEN="secret-value"line is still printed, because printing the variables is whatide envdoes.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat).If no issue ID exists, title only.
In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed,you have updated our LICENSE.adoc