Repository navigation
#2705: fix obsidian detection on Windows - #2707
Open
Ali-Shariati-Najafabadi wants to merge 6 commits into
Open
Ali-Shariati-Najafabadi wants to merge 6 commits into
Ali-Shariati-Najafabadi wants to merge 6 commits into
Conversation
Collaborator
Coverage Report for CI Build 41042776190Coverage increased (+0.04%) to 75.324%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions44 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
hohwille
approved these changes
Oct 22, 2026
hohwille
left a comment
Member
There was a problem hiding this comment.
@Ali-Shariati-Najafabadi thanks for your PR. Your fix looks plausible to me and explains the strange effect that Nodepad++ was getting uninstalled instead of Obsidian. 👍
I leave this in team-review so a team-reviewer can especially test your fix manually before we merge but from my quick review look this seems fully correct and great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2705
ide obsidianreinstalled Obsidian on every call andide get-version obsidianreported the version of Notepad++. The registry lookup for the uninstall key took the first match ofreg query /s /f, which also matches unrelated values, and Obsidian is not in the PATH so the existing installation was never found.Implemented changes:
WindowsHelperImpl.findUninstallKeyonly accepts a key whoseDisplayNamecontains the app name.Obsidianfinds its installation directory via the Windows registry (same approach asPgAdmin), so an installed Obsidian is detected and launched instead of reinstalled.WindowsHelperImplTestandObsidianTest, and the CHANGELOG entry.Testing instructions
ide obsidianand finish the installer.ide -d get-version obsidianand verify that the installed version is the Obsidian version and not the one of another tool.ide obsidianagain and verify that no installer is started and Obsidian is launched.mvn -Dtest=ObsidianTest,WindowsHelperImplTest testin theclifolder.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat).If no issue ID exists, title only.
In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed,you have updated our LICENSE.adoc