Repository navigation
Conversation
…rage to 100%(line).
…rage to 100%(line).
…yling # Conflicts: # cli/src/test/java/com/devonfw/tools/ide/merge/PropertiesMergerTest.java # gui/src/main/java/com/devonfw/ide/gui/core/mainwindow/console/ConsoleController.java # gui/src/main/resources/com/devonfw/ide/gui/core/mainwindow/console/console.fxml
Collaborator
Coverage Report for CI Build 41049914912Coverage increased (+0.004%) to 75.292%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions3 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
stphschne
marked this pull request as ready for review
October 19, 2026 10:13
samuelkos17
suggested changes
Oct 27, 2026
Contributor
Author
|
I did address every mentioned point of yours: I deleted the consoleController.css, added the stylesheets to the fxml-files and moved the css-files into the styles-folder. No hard-coded css found anymore. |
samuelkos17
suggested changes
Oct 29, 2026
samuelkos17
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing my comments, this is almost done now, good job! 😄
There are just a few things that still need to be done:
- ConsoleView.css is never loaded in console.fxml, but besides that we don't really need an extra file for that, you could just take the content from ConsoleView.css and move it to console.css and delete ConsoleView.css
- I would suggest keeping the .css files names lower-case
…ConsoleView.java Co-authored-by: Samuel Kostiuk <148919667+samuelkos17@users.noreply.github.com>
…ne/IDEasy into 2482-Improve-CSS-Styling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2482
Implemented changes:
Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
1.Run AppLauncher.java. Styling should stay the same.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat).If no issue ID exists, title only.
In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed,you have updated our LICENSE.adoc
Checklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandletChecklist for GUI contributions
Did you make user-facing changes to the GUI? There are the following additional checks: