Skip to content

#2482: improve css styling - #2699

Open
stphschne wants to merge 49 commits into
devonfw:mainfrom
stphschne:2482-Improve-CSS-Styling
Open

stphschne wants to merge 49 commits into
devonfw:mainfrom
stphschne:2482-Improve-CSS-Styling

Conversation

@stphschne

@stphschne stphschne commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes #2482

Implemented changes:

  • Change 1: Added console.css
  • Change 2: Added MainWindowView.css
  • Change 3: Added ConsoleView.css

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

1.Run AppLauncher.java. Styling should stay the same.


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat).
    If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed,
    you have updated our LICENSE.adoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

Checklist for tool commandlets

Have you added a new «tool» as commandlet? There are the following additional checks:

  • The tool can be installed automatically (during setup via settings) or via the commandlet call
  • The tool is isolated in its IDEasy project, see Sandbox Principle
  • The new tool is added to the table of tools in LICENSE.asciidoc
  • The new commandlet is a command-wrapper for «tool»
  • Proper help texts for all supported languages are added here
  • The new commandlet installs potential dependencies automatically
  • The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
  • The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue

Checklist for GUI contributions

Did you make user-facing changes to the GUI? There are the following additional checks:

  • You followed the ui-contribution-process.adoc and ui-structure.adoc
  • The UI changes are designed in the Figma project and the design was approved in the team review
  • You have added screenshots of the UI changes to the PR description

@coveralls

coveralls commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 41049914912

Coverage increased (+0.004%) to 75.292%

Details

  • Coverage increased (+0.004%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 3 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/ide/gui/core/mainwindow/console/ConsoleView.java 2 86.0%
com/devonfw/tools/ide/version/VersionSegment.java 1 89.24%

Coverage Stats

Coverage Status
Relevant Lines: 19908
Covered Lines: 15644
Line Coverage: 78.58%
Relevant Branches: 8848
Covered Branches: 6007
Branch Coverage: 67.89%
Branches in Coverage %: Yes
Coverage Strength: 3.38 hits per line

💛 - Coveralls

@stphschne
stphschne marked this pull request as ready for review October 19, 2026 10:13
@stphschne stphschne added the enhancement New feature or request label Oct 19, 2026
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Oct 22, 2026
@samuelkos17 samuelkos17 moved this from 🆕 New to Team Review in IDEasy board Oct 22, 2026
@stphschne
stphschne requested a review from samuelkos17 October 23, 2026 12:34

@samuelkos17 samuelkos17 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, before reviewing this again I would ask you to address all my points from my previous review or tell me why you didn't address them. If you need help, please contact me on Teams.

@stphschne

Copy link
Copy Markdown
Contributor Author

I did address every mentioned point of yours: I deleted the consoleController.css, added the stylesheets to the fxml-files and moved the css-files into the styles-folder. No hard-coded css found anymore.

@laim2003 laim2003 changed the title 2482 improve css styling #2482 improve css styling Oct 29, 2026
@laim2003 laim2003 changed the title #2482 improve css styling #2482: improve css styling Oct 29, 2026

@samuelkos17 samuelkos17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, this is almost done now, good job! 😄

There are just a few things that still need to be done:

  • ConsoleView.css is never loaded in console.fxml, but besides that we don't really need an extra file for that, you could just take the content from ConsoleView.css and move it to console.css and delete ConsoleView.css
  • I would suggest keeping the .css files names lower-case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Improve CSS styling implementation of the UI

4 participants