#2197: fixed-python-integration#2205
Open
JoelAdbu wants to merge 2 commits into
Open
Conversation
- set UV_PROJECT_ENVIRONMENT for uv project commands -added test to check if UV_PROJECT_ENVIROMENT is set
Collaborator
Coverage Report for CI Build 30004650583Coverage increased (+0.05%) to 72.542%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
Contributor
Author
|
This solution is based on the uv maintainers' recommendation: Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2197
Implemented changes:
UV_PROJECT_ENVIRONMENTenvironment variable for python installations.UV_PROJECT_ENVIRONMENTenvironment setup.Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Prerequisites
pyproject.tomlfile in the workspace root:Reproduce Current Behavior
VIRTUAL_ENVis set:Expected:
UV_PROJECT_ENVIRONMENTis not set:Expected:
and
.venvfolder should have been created in the workspace`.venvinstead of the IDEasy Python environment.Cleanup Before Testing the Fix
4 . Remove the installed Python environment:
Test the fix
Checkout Branch containing the fix
Build IDEasy Locally
Wait until the build completes successfully.
Check:
Expected for both:
Result
The fix is successful if:
uv syncuses the IDEasy Python installationsoftware/pythonUV_PROJECT_ENVIRONMENTis set automaticallyVIRTUAL_ENV.venvdirectory is createdChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal