#2186: create obsidian url updater#2203
Open
JoelAdbu wants to merge 1 commit into
Open
Conversation
- Add Obsidian URL updater, test and release mock data added Obsidian url updater to updateManager
JoelAdbu
added
enhancement
vivu001
reviewed
Jul 24, 2026
| doAddVersion(urlVersion, baseUrl + "Obsidian-${version}.exe", WINDOWS, X64); | ||
| doAddVersion(urlVersion, baseUrl + "Obsidian-${version}.dmg", MAC, X64); | ||
| doAddVersion(urlVersion, baseUrl + "obsidian_${version}_amd64.deb", LINUX, X64); | ||
| doAddVersion(urlVersion, baseUrl + "obsidian-${version}.tar.gz", LINUX, X64); |
Contributor
There was a problem hiding this comment.
Obsidian also publishes an arm64 Linux tarball, so add a separate pattern for obsidian-${version}-arm64.tar.gz
Contributor
|
I’ve run the tests and everything passed successfully. The implementation looks good and follows a proper approach. One minor remark: please update the changelog before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2186
Implemented changes:
Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
mvn clean test.ObsidianUrlUpdaterTestpasses.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal