#2176: Add 7z archive extraction support#2177
Open
laert-ll wants to merge 14 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 29939760396Coverage increased (+0.07%) to 72.561%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions186 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
laert-ll
force-pushed
the
feature/2176-7z-extraction-support
branch
2 times, most recently
from
July 21, 2026 10:25
9b6a208 to
43c5584
Compare
laert-ll
marked this pull request as ready for review
July 21, 2026 13:26
laert-ll
force-pushed
the
feature/2176-7z-extraction-support
branch
from
July 22, 2026 04:58
7b4ff69 to
c89c706
Compare
vivu001
reviewed
Jul 22, 2026
Contributor
|
I tried building the app with GraalVM, but it hit these errors: |
Contributor
Author
|
@vivu001 Thanks for the the GraalVM test and the error output, I applied some changes, could you please test it again? |
Contributor
|
I followed the testing instructions, including the optional Ruby branch rebase and end-to-end The 7z extraction path, progress reporting, and Ruby installation all behave as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2176
Implemented changes:
extract7ztoFileAccess/FileAccessImpl(using Apache Commons Compress).Testing instructions
Run the 7z tests:
mvn -Dtest=FileAccessImplTest#test7zExtraction+test7zExtractionWithFilePermissions+test7zExtractionWithSymbolicLink -pl cli testand check if all three pass.Optional: What would also properly test the functionality, is switching to the Ruby branch, rebasing this branch onto it, and testing that the Ruby installation goes through, where we can actually see the 7z extraction process (along with the progress bars and everything).
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal