Skip to content

#2039: Added workaround for app icon in MacOS Dock#2161

Open
oanding-blrng wants to merge 7 commits into
devonfw:mainfrom
oanding-blrng:fix/2039-IDE-logo-not-shown-in-mac-task-bar
Open

#2039: Added workaround for app icon in MacOS Dock#2161
oanding-blrng wants to merge 7 commits into
devonfw:mainfrom
oanding-blrng:fix/2039-IDE-logo-not-shown-in-mac-task-bar

Conversation

@oanding-blrng

@oanding-blrng oanding-blrng commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This PR fixes: #2039

Implemented changes:

  • Added method in App.java to set icon in taskbar/dock in macOS with workaround and condition to only call new method, if we are on a macOS system

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Start the ide gui with AppLauncher
  2. The icon defined under gui/src/main/resources/com/devonfw/ide/gui/assets/devonfw.png will be used as the icon in the taskbar/dock

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jul 14, 2026
@oanding-blrng oanding-blrng self-assigned this Jul 14, 2026
@oanding-blrng oanding-blrng added macOS specific for Apple MacOS bugfix PR that fixes a bug issue GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx labels Jul 14, 2026
@oanding-blrng oanding-blrng moved this from 🆕 New to 🏗 In progress in IDEasy board Jul 14, 2026
@coveralls

coveralls commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 30004921902

Coverage decreased (-0.04%) to 72.458%

Details

  • Coverage decreased (-0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 30 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

30 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/ide/gui/App.java 30 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 16969
Covered Lines: 12822
Line Coverage: 75.56%
Relevant Branches: 7586
Covered Branches: 4970
Branch Coverage: 65.52%
Branches in Coverage %: Yes
Coverage Strength: 3.2 hits per line

💛 - Coveralls

@oanding-blrng

Copy link
Copy Markdown
Contributor Author

As of time of writing two tests regarding the localization are failing:

[ERROR] Tests run: 15, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.224 s <<< FAILURE! -- in com.devonfw.ide.gui.nls.NlsServiceTest
[ERROR] com.devonfw.ide.gui.nls.NlsServiceTest.testLanguageDisplayShowsLocaleName -- Time elapsed: 0.018 s <<< FAILURE!
org.opentest4j.AssertionFailedError:

expected: "English (en)"
 but was: "Deutsch (de)"
        at com.devonfw.ide.gui.nls.NlsServiceTest.testLanguageDisplayShowsLocaleName(NlsServiceTest.java:113)
        at java.base/java.lang.reflect.Method.invoke(Method.java:565)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)

[ERROR] com.devonfw.ide.gui.nls.NlsServiceTest.testGetInstanceWithLocale -- Time elapsed: 0.007 s <<< FAILURE!
org.opentest4j.AssertionFailedError:

expected: "English (en)"
 but was: "Deutsch (de)"
        at com.devonfw.ide.gui.nls.NlsServiceTest.testGetInstanceWithLocale(NlsServiceTest.java:66)
        at java.base/java.lang.reflect.Method.invoke(Method.java:565)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)

All other tests are running successfully.

@oanding-blrng
oanding-blrng marked this pull request as ready for review July 14, 2026 13:18
@oanding-blrng oanding-blrng moved this from 🏗 In progress to Team Review in IDEasy board Jul 14, 2026
@oanding-blrng oanding-blrng changed the title Fix/2039 ide logo not shown in mac task bar #2039: Added workaround for app icon in MacOS Dock Jul 15, 2026
@laim2003 laim2003 self-assigned this Jul 23, 2026
@laim2003
laim2003 self-requested a review July 23, 2026 08:37

@laim2003 laim2003 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oanding-blrng, works like a charm!

@laim2003
laim2003 self-requested a review July 23, 2026 12:44

@laim2003 laim2003 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oanding-blrng , works like a charm!

@laim2003 laim2003 moved this from Team Review to 👀 In review in IDEasy board Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx macOS specific for Apple MacOS

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

IDE logo not shown in mac task bar

3 participants