#1808: do not report a workspace when icd navigates to the project root#2125
#1808: do not report a workspace when icd navigates to the project root#2125maybeec wants to merge 2 commits into
Conversation
Coverage Report for CI Build 28850392142Coverage increased (+0.02%) to 72.087%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
hohwille
left a comment
There was a problem hiding this comment.
@maybeec thanks for your PR.
In order not to be biased here, I asked the developer team and they said that they see this as a kind of pointless complexity and partially also source of confusion.
We even discussed to go for KISS and simply always remove the workspace information.
However, there were arguments that the workspace information is valuable since this is important when opening an IDE and also some IDEasy projects use workspace specific ide.properties.
As a first step I will remove the release association.
Next lets see if we can still come to an agreement here since you already provided the PR I do not easily want to abandon your work.
This PR fixes #1808
Implemented changes:
icdcommand (and the sharedideshell integration it reuses) no longer claims you arein workspace mainwhen you actually navigate to the project root.workspaces/<name>folder:icd -p «project»→IDE environment variables have been set for «home»(no workspace mentioned)icd -p «project» -w [«name»]→... in workspace «name»(unchanged)icdinside a project → jumps to the project root →... for «home»(no workspace)icdwith no project → only navigates to the projects root (IDE_ROOT), no environment setup and no message (unchanged)ide.batwrapper for cross-platform consistency.cli.adoc,features.adoc) and added aCHANGELOG.adocentry.This is a message-only change; the navigation semantics of
-p/-w(as designed and discussed in the issue) are unchanged.Testing instructions
bash cli/src/test/functions-test.sh— all tests pass (includes newicdmessage tests covering project-root vs. workspace).icd -p «project». The output must readIDE environment variables have been set for «...»/«project»withoutin workspace main.icd -p «project» -wand confirm it still reports... in workspace main(you are now inside the workspace).icdand confirm it jumps to the project root and reports... for «home»without a workspace.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)internal