Repository navigation
Conversation
Replace serial per-object deletion with provider delete_batch/max_delete_batch: S3-compatible vendors use DeleteObjects, Aliyun/Huawei/Tencent use their native multi-delete APIs, and B2/UPYUN fall back to bounded concurrency. Recursive deletion now fails closed at 20k objects by default, supports an explicit streaming override, preserves directory markers when any file fails, reports partial-failure summaries, and is cancellable from the transfer panel.
Replace the flat done/total delete event with a tagged stream: preparing reports scanned entries, deleting_files carries file-phase counts plus discovered/failed, and cleaning_directories covers directory markers and the root marker. Recursive deletion now shows preparation progress before any object is removed, keeps the transfer row in a waiting state at the 20k guard, and reuses that row for the explicit streaming pass. Cancellation reports 'cancelling' until the backend reaches a batch boundary. The transfer panel renders indeterminate preparation, phase-local counts, live failures, and the final deleted/failed summary, with a failure-detail dialog for the recorded samples. Throttle events to 100ms in the Tauri adapter while always delivering phase transitions and the final frame. Stale delete transfer records are dropped on restore because their persisted shape lacks failure counts and would overstate successful deletions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete_objects) for S3-compatible storage, Aliyun OSS, Huawei OBS, and Tencent COS, so selected objects are deleted in provider-sized batches instead of one request per key.preparing→deleting_files→cleaning_directories) through coalesceddelete-progressevents (100 ms), with per-phase counts, batch-boundary cancellation, and a failure dialog that samples up to five errors.Verification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-featurescd app && pnpm build