Skip to content

fix(noweb): use stream mode for media download to fix 0-byte audio files #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-rudaev wants to merge 1 commit into
base: core
Choose a base branch
from
Open

fix(noweb): use stream mode for media download to fix 0-byte audio files #1997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/core/engines/noweb/session.noweb.core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2848,9 +2848,12 @@ export class NOWEBEngineMediaProcessor implements IMediaEngineProcessor<any> {
content.url = null;
}

return (await downloadMediaMessage(
// Use 'stream' mode instead of 'buffer' to fix 0-byte audio files
// 'buffer' mode silently returns empty buffer for audio/voice messages
// See: https://github.com/devlikeapro/waha/issues/1996
const stream = await downloadMediaMessage(
message,
'buffer',
'stream',
{},
{
logger: this.logger,
Expand All @@ -2859,7 +2862,12 @@ export class NOWEBEngineMediaProcessor implements IMediaEngineProcessor<any> {
).finally(() => {
// Set url back in case we removed it
content.url = url;
})) as Buffer;
});
const chunks: Buffer[] = [];
for await (const chunk of stream) {
chunks.push(chunk);
}
return Buffer.concat(chunks);
}

getFilename(message: any): string | null {
Expand Down