compiler: Misc enhancements for lowering of parlang backends by FabioLuporini · Pull Request #2878 · devitocodes/devito

FabioLuporini · 2026-03-30T11:12:47Z

No description provided.

FabioLuporini · 2026-03-30T11:13:10Z

devito/ir/support/properties.py

    if not exprs:
        return properties

-    # Auto-detect prefetchable Dimensions


now unused, hence dropping

FabioLuporini · 2026-03-30T11:13:47Z

devito/passes/clusters/aliases.py

    return schedule.rebuild(*processed, rmapper=rmapper)


+def optimize_schedule_maxpar(schedule):


this is 95% just like before, but it now also triggers in some rare cases excited in PRO

FabioLuporini · 2026-03-30T11:13:59Z

devito/types/dense.py

    def _time_buffering_default(self):
        return self._time_buffering and not isinstance(self.save, Buffer)

-    def _evaluate(self, **kwargs):


@mloubout dropped as per your suggestion

codecov · 2026-03-30T11:34:46Z

Codecov Report

❌ Patch coverage is 84.33735% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.44%. Comparing base (c189f61) to head (aa388f3).

Files with missing lines	Patch %	Lines
devito/ir/iet/efunc.py	57.14%	9 Missing ⚠️
devito/ir/clusters/cluster.py	90.00%	3 Missing ⚠️
devito/types/parallel.py	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2878      +/-   ##
==========================================
+ Coverage   83.42%   83.44%   +0.02%     
==========================================
  Files         248      248              
  Lines       51262    51311      +49     
  Branches     4431     4428       -3     
==========================================
+ Hits        42765    42819      +54     
- Misses       7735     7736       +1     
+ Partials      762      756       -6

Flag	Coverage Δ
pytest-gpu-aomp-amdgpuX	`68.79% <81.57%> (+0.03%)`	⬆️
pytest-gpu-gcc-	`78.05% <84.33%> (+0.02%)`	⬆️
pytest-gpu-icx-	`77.68% <84.33%> (+0.05%)`	⬆️
pytest-gpu-nvc-nvidiaX	`69.33% <81.57%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout · 2026-03-30T16:08:06Z

devito/ir/iet/efunc.py

+    libs: tuple = ()
+
+    @classmethod
+    def from_body(cls, body):


Does this really need a method? That just EFuncMetadata(body=body)

Actually, it does improve readability elsewhere, so I'm not entirely opposed

no, AI garbage, removing

mloubout · 2026-03-30T16:09:05Z

devito/ir/iet/efunc.py

+
+    @classmethod
+    def compose(cls, *items):
+        items = tuple(i for i in items if i is not None)


Why would an item be None?

AI garbage leftover, removing

devito/ir/iet/efunc.py

mloubout · 2026-03-30T16:12:17Z

devito/ir/iet/efunc.py



+@dataclass(frozen=True)
+class EFuncMetadata:


Since this clearly looks like it's for an IET pass return, it should be used throughout or at least for the efunc realted ones.

yes, one of the reasons I put it in OSS... but that would be massive changes, I'd rather do it incrementally

also, changing the name to EFuncMeta

EdCaunt · 2026-03-31T10:39:13Z

devito/ir/iet/efunc.py

+    libs: tuple = ()
+
+    @classmethod
+    def from_body(cls, body):


EdCaunt · 2026-03-31T11:10:29Z

devito/types/parallel.py

    pass


+class ThreadArrive(Fence):


Is this to make use of more sophisticated/granular thread barriers to reduce idle time somewhere?

pretty much yes

FabioLuporini added 5 commits March 30, 2026 12:07

compiler: Patch premature evaluation of saved TimeFunctions

c65c28a

compiler: Tweak CIRE max-par lowering

3f7f6dc

compiler: Add ThreadArrive and TensorMove

1df126b

compiler : Add Cluster.is_thread_sync

4ab49c8

compiler: Add EFuncMetadata

9d34058

FabioLuporini requested review from EdCaunt, JDBetteridge and mloubout March 30, 2026 11:12

FabioLuporini added the compiler label Mar 30, 2026

FabioLuporini commented Mar 30, 2026

View reviewed changes

misc: Fix isort

8b6731a

mloubout reviewed Mar 30, 2026

View reviewed changes

EdCaunt reviewed Mar 31, 2026

View reviewed changes

FabioLuporini added 2 commits April 1, 2026 16:39

compiler: Simplify EFuncMetadata

c61b8cc

compiler: Add PhaseMarker

aa388f3

FabioLuporini force-pushed the more-TMA-enhance branch from 9f1fe85 to aa388f3 Compare April 2, 2026 13:29

mloubout approved these changes Apr 2, 2026

View reviewed changes

		return schedule.rebuild(*processed, rmapper=rmapper)


		def optimize_schedule_maxpar(schedule):



		@dataclass(frozen=True)
		class EFuncMetadata:

Conversation

FabioLuporini commented Mar 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 30, 2026 •

edited

Loading