new icon: deepseek (original, original-wordmark, plain-wordmark)#2664
new icon: deepseek (original, original-wordmark, plain-wordmark)#2664Supritha-AV wants to merge 6 commits intodevicons:developfrom
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.1 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
weh
changed the title
weh
changed the title
weh
left a comment
weh
left a comment
There was a problem hiding this comment.
Hi @Supritha-AV, thanks for your contribution.
I found a couple of issues, that you should fix, before we can merge.
I already fixed the pull request template for you. Also the title was not matching the PR content.
the current original-wordmark file can not be used for the font. Font svg need to have a single color, which is not the case here. But you can copy the original-wordmark.svg and change it to be used as plain-wordmkar.svg just by changing the color of the font, to be the same as the whale. Also you can combine the two path, to be a single one.
the current original svg looks a bit squished. Make sure to keep the aspect ratio of the original image, when you edit the image size. This needs to be fixed here.
You can add an alias plain for this original file, since it should be only a single path and color already.
so in the end you should have three files, deepseek-original.svg, deepseek-original-wordmark.svg and deepseek-plain.svg.
Also do not forget to optimize the images using OMGSVG or something similar.
You can find some information about Tools and requirements in our wiki, or ask if something is unclear :)
Cheers Patrik
weh
added
the
feature:icon
weh
left a comment
weh
left a comment
There was a problem hiding this comment.
...oh i also forgot, devicon.min.css, icomoon.json and package-lock.json should not be part of your pull request.
2 participants
Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereThis PR closes #2651
Link to prove your SVG is correct and up-to-date.
Official DeepSeek reference/logo: https://www.deepseek.com