Repository navigation
perf(cloud): poll results with ?view=summary and If-None-Match - #219
Merged
Merged
Conversation
The dcd cloud poll loop fetched every result row in full, including result_files and its main_log, every 20-60s, even when nothing had changed. It now asks for ?view=summary, which an older API ignores (returning the full rows, a superset), and revalidates with the last ETag so an unchanged poll is an empty 304. The conditional request also sends Cache-Control: max-age=0. Without it undici appends Cache-Control: no-cache, and Express then never answers 304. Only a non-empty result set with an ETag is cached; the 200 error envelope and empty sets are not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dcd cloud poll loop fetched every result row in full, including result_files and its main_log, every 20-60s, even when nothing had changed. It now asks for ?view=summary, which an older API ignores (returning the full rows, a superset), and revalidates with the last ETag so an unchanged poll is an empty 304.
The conditional request also sends Cache-Control: max-age=0. Without it undici appends Cache-Control: no-cache, and Express then never answers 304. Only a non-empty result set with an ETag is cached; the 200 error envelope and empty sets are not.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test