feat: adds support for randomly generated admin password on first run #755
+453
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
+ Coverage 39.66% 39.93% +0.27%
==========================================
Files 112 113 +1
Lines 10652 10729 +77
==========================================
+ Hits 4225 4285 +60
- Misses 6046 6059 +13
- Partials 381 385 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rsdmike
force-pushed
the
randomPassword
branch
from
97528fe to
d448667
Compare
For a long time, we have used G@ppm0ym as a standard static default password. This PR removes the static password. The goal has been for users to always integrate their own authentication with role based auth. That said, we understand this doesn't always happen. As such, randomly generating a password on first run when no static password is provided will adhere to better security practices. Existing users should have the `adminPassword` and therefore be unaffected by this change.
rsdmike
force-pushed
the
randomPassword
branch
from
d448667 to
5c92bf9
Compare
rsdmike
changed the title
Contributor
2. Able to log in from the UI using the generated random password.
3. Incorrect credentials prevent login; the error message on the UI needs to be updated (not in the scope of this PR).
4. Removed the generated password from Windows Credentials and updated it in the ENV file; this worked as well.
The code looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, we have used
G@ppm0ymas a standard static default password. This PR removes the static password. The goal has been for users to always integrate their own authentication with role based auth. That said, we understand this doesn't always happen. As such, randomly generating a password on first run when no static password is provided will help adhere to better security practices. Existing users should have theadminPasswordand therefore be unaffected by this change.