Fix youtube-ctx timestamp units - #14
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
devhims
marked this pull request as ready for review
August 19, 2026 12:14
devhims
force-pushed
the
fix/youtube-ctx-timestamp-units
branch
from
August 19, 2026 12:18
04726b7 to
f5ac086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--timestamps-msfor storyboard-derived millisecond values while preserving--timestampsfor secondsWhy
The storyboard index and its tile formula expose milliseconds, while the exact-frame CLI accepted seconds. The skill reference did not make that boundary explicit, so agents could pass storyboard millisecond values to
--timestampsand have them interpreted as seconds.Impact
Storyboard-derived values now have a unit-explicit path with no rescaling. Existing seconds-based callers remain compatible, and invalid calls provide enough information to correct the unit instead of retrying speculatively.
Validation
npm run verifyinpackages/youtube-skills(30 passed, 2 skipped)