fix: initialize macOS audio output safely - #385
Merged
devgianlu merged 3 commits intoSep 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, the daemon defaults to ALSA. Selecting AudioToolbox instead exposes a retained Go pointer in C memory (fatal under
cgocheck2), and the queue ignoresInitialVolumeat startup.This change defaults to AudioToolbox on macOS, uses
runtime/cgo.Handlewith cleanup after queue disposal, applies the initial volume before playback, and fixes initialization errors and blocking callback error delivery.Validated on macOS 26.6.2 / arm64 with Go 1.25.5 and 1.27.1:
-raceandcgocheck2, covering initial mute, volume changes, GC, pause/resume, and repeated Close.Tests and reproduction instructions are included. Hardware tests are opt-in and use generated silence.
Spotify track playback on the tested account still fails with
failed retrieving aes key with code 1; this PR addresses native audio output, and does not resolve that separate issue. Fork CI passes Linux/macOS/Windows tests and Windows cross-compilation; upstream CI awaits approval.