AMP-31202 : Audit clarifications - #4512
Open
brianbrix wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds user-facing policy disclosures around authentication/registration flows and introduces two static policy pages intended to support audit/privacy clarifications.
Changes:
- Add a short Privacy Policy acknowledgment notice to public portal login, login widget, and user registration pages.
- Add new static pages for the AMP Privacy Policy and AMP Code of Conduct under the webapp root.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| amp/TEMPLATE/ampTemplate/layout/publicPortalLogin.jsp | Adds a Privacy Policy acknowledgment notice above the member login form. |
| amp/TEMPLATE/ampTemplate/layout/loginWidget3.jsp | Adds a Privacy Policy acknowledgment line within the login widget form. |
| amp/src/main/webapp/WEB-INF/jsp/aim/view/userRegistration.jsp | Adds a Privacy Policy notice near the top of the registration form. |
| amp/src/main/webapp/privacy-policy.html | Introduces a static Privacy Policy page for deployments to link to. |
| amp/src/main/webapp/code-of-conduct.html | Introduces a static Code of Conduct page for deployments to link to. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (1)
amp/src/main/webapp/code-of-conduct.html:40
- The Code of Conduct page links to
https://github.com/devgateway/amp/blob/main/CODE_OF_CONDUCT.md, but there is noCODE_OF_CONDUCT.mdfile in this repository, so this link will 404 for users.
<p>This page is the web version of the repository <a href="https://github.com/devgateway/amp/blob/main/CODE_OF_CONDUCT.md">Code of Conduct</a>.</p>
Add license metadata to pom.xml
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (2)
Previously missed (1) — in code that hasn't changed since the last review.
amp/TEMPLATE/ampTemplate/layout/loginWidget3.jsp:67
- The privacy notice text here differs from the one shown on the public portal login page (publicPortalLogin.jsp), which can lead to inconsistent audit messaging across login entry points. Consider standardizing the wording between the two login forms.
<p style="font-size:11px; line-height:15px; margin:6px 0;">
<digi:trn>By signing in, you acknowledge the</digi:trn>
<a href="/privacy-policy.html"><digi:trn>Privacy Policy</digi:trn></a>.
</p>
amp/src/main/webapp/code-of-conduct.html:40
- This page says it is the web version of a repository "Code of Conduct" file, but there is no CODE_OF_CONDUCT.md (or similarly named) file in the repository, so this link will likely 404. Either add the referenced markdown file or remove/update this sentence to avoid pointing users to a broken URL.
<p>This page is the web version of the repository <a href="https://github.com/devgateway/amp/blob/main/CODE_OF_CONDUCT.md">Code of Conduct</a>.</p>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (2)
Previously missed (1) — in code that hasn't changed since the last review.
amp/src/main/webapp/privacy-policy.html:22
- The page is newly added/updated in this PR, but the "Last updated" date still says August 2022, which is misleading and will quickly become stale. Update it to the current update month/year (or remove the date if it’s not intended to be maintained).
<h1>AMP Privacy Policy</h1>
<p class="meta">Last updated: August 2022</p>
amp/src/main/webapp/code-of-conduct.html:40
- This HTML page claims to be the web version of the repository Code of Conduct, but it currently omits the final paragraph present in CODE_OF_CONDUCT.md (administration/update notice). Either include that paragraph here or adjust the statement so it no longer implies parity with the Markdown file.
<h2>Enforcement</h2>
<p>Project maintainers may remove comments, close discussions, restrict participation, or take other appropriate action when this Code of Conduct is violated. Serious or repeated violations may be referred to the appropriate organisational or legal process.</p>
<p>This page is the web version of the repository <a href="https://github.com/devgateway/amp/blob/main/CODE_OF_CONDUCT.md">Code of Conduct</a>.</p>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 27 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
Previously missed (2) — in code that hasn't changed since the last review.
amp/TEMPLATE/ampTemplate/layout/publicPortalLogin.jsp:71
- The privacy notice sentence is split across multiple digi:trn tags around an link, which prevents translators from reordering the sentence naturally in languages where the link text placement differs. Consider using a single translation string with a {0} placeholder and pass the full anchor as arg1, so the whole sentence can be translated/reordered as one unit.
<div class="login-privacy-notice" style="font-size:11px; line-height:16px; margin:0 20px 10px; color:#555;">
<digi:trn>By signing in, you acknowledge that AMP processes account and activity information according to the</digi:trn>
<a href="/privacy-policy.html"><digi:trn>Privacy Policy</digi:trn></a>.
</div>
amp/src/main/webapp/WEB-INF/jsp/aim/view/userRegistration.jsp:230
- The registration privacy notice is broken into multiple digi:trn fragments around an tag, which limits translators’ ability to reorder/inflect the sentence naturally. Consider using a single translation string with a {0} placeholder and pass the full anchor via arg1.
<div class="registration-privacy-notice" style="font-size:12px; line-height:18px; margin:10px auto 14px; max-width:650px; text-align:left; color:#555;">
<digi:trn>To create an AMP account, you provide account information such as your name and email address.</digi:trn>
<digi:trn>Read the</digi:trn> <a href="/privacy-policy.html"><digi:trn>Privacy Policy</digi:trn></a>
<digi:trn>before registering. By submitting this form, you confirm that the information you provide may be used to create and administer your AMP account.</digi:trn>
</div>
Comment on lines
+64
to
+67
| <p style="font-size:11px; line-height:15px; margin:6px 0;"> | ||
| <digi:trn>By signing in, you acknowledge that AMP processes account and activity information according to the</digi:trn> | ||
| <a href="/privacy-policy.html"><digi:trn>Privacy Policy</digi:trn></a>. | ||
| </p> |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are additive and low-risk (static policy pages, small JSP text additions, and licensing/metadata updates) with no functional regressions identified.
Review details
- Files reviewed: 25/28 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.