feat: add optional columns property to resource data request schema a…#601
Merged
feat: add optional columns property to resource data request schema a…#601
Conversation
…nd implement column validation in AdminForthRestAPI
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an optional columns parameter to the /get_resource_data request to allow callers to request a subset of resource columns, and threads that selection through the REST API layer down into the various data connectors so they can fetch fewer fields from the datasource.
Changes:
- Extend connector interfaces and base connector logic to accept an optional
columnslist when fetching resource data. - Add
columnsto the/get_resource_datarequest schema and implement server-side validation + response shaping based on selected columns. - Update SQL/Mongo/ClickHouse connectors to apply column selection at query/projection time.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| adminforth/types/Back.ts | Extends connector interface method signatures to support optional selected columns. |
| adminforth/modules/restApi.ts | Adds request schema support for columns and applies validation + conditional post-processing in /get_resource_data. |
| adminforth/dataConnectors/baseConnector.ts | Threads selected datasource columns into getDataWithOriginalTypes() and limits value transformation to selected columns. |
| adminforth/dataConnectors/sqlite.ts | Uses selected columns to build the SQLite SELECT list. |
| adminforth/dataConnectors/postgres.ts | Uses selected columns to build the Postgres SELECT list (quoted identifiers). |
| adminforth/dataConnectors/mysql.ts | Uses selected columns to build the MySQL SELECT list. |
| adminforth/dataConnectors/mongo.ts | Applies selected columns as a Mongo projection. |
| adminforth/dataConnectors/clickhouse.ts | Uses selected columns to build the ClickHouse SELECT list (including DECIMAL casting). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… adding polymorphic car references, and expanding test coverage for resource data retrieval
…ields and enhance test coverage for resource data retrieval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd implement column validation in AdminForthRestAPI