Skip to content

Conversation

@vinokurig
Copy link
Contributor

Description of Changes

  • add new java quarkus devfile version based on ubi9/openjdk-21 container
  • use pure mvn command instead of the ./mvnw wrapper script

The ./nvmw wrapper script fails to untar the downloaded maven binaries because the required targz tool is missing in the openjdk container. To fix that we call maven directly. The ubi9/openjdk-21 container contains the proper maven version which is compatible with quarkus.

Related Issue(s)

fixes eclipse-che/che#23651

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@openshift-ci
Copy link

openshift-ci bot commented Dec 29, 2025

Hi @vinokurig. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vinokurig
Copy link
Contributor Author

/ok-to-test

@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2026

@vinokurig: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@thepetk
Copy link
Contributor

thepetk commented Jan 12, 2026

/ok-to-test

/retest

@svor
Copy link
Collaborator

svor commented Jan 13, 2026

/retest

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 14, 2026
@svor
Copy link
Collaborator

svor commented Jan 19, 2026

/retest

1 similar comment
@svor
Copy link
Collaborator

svor commented Jan 26, 2026

/retest

@svor
Copy link
Collaborator

svor commented Jan 26, 2026

@thepetk hello, could you please take a look at the failed PR check? It doesn’t seem to be related to the current changes.

@thepetk
Copy link
Contributor

thepetk commented Jan 26, 2026

/retest

@vinokurig yeah I agree, there's an open issue we're currently working at. I'm going to retest one more time to see if there's anything wrong and then I'll approve merge.

@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2026

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.16-registry-test 0482332 link true /test v4.16-registry-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michael-valdron I think we could merge this one, I just don't have the perms to by-pass the ruleset.

@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibuziuk, thepetk, vinokurig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not start workspace for the quarkus sample

4 participants