Skip to content

Fix: check for empty storage in common storage provisioner #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Allda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: check for empty storage in common storage provisioner #1577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/library/storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@ func GetWorkspacePVCInfo(
if err != nil {
return "", "", err
}
if !storageProvisioner.NeedsStorage(&workspace.Spec.Template) {
// No storage provisioned for this workspace
return "", "", nil
}

if _, ok := storageProvisioner.(*storage.PerWorkspaceStorageProvisioner); ok {
pvcName := common.PerWorkspacePVCName(workspace.Status.DevWorkspaceId)
return pvcName, constants.DefaultProjectsSourcesRoot, nil

} else if _, ok := storageProvisioner.(*storage.CommonStorageProvisioner); ok {
if !storageProvisioner.NeedsStorage(&workspace.Spec.Template) {
// No storage provisioned for this workspace
return "", "", nil
}
pvcName := constants.DefaultWorkspacePVCName
if config.Workspace != nil && config.Workspace.PVCName != "" {
pvcName = config.Workspace.PVCName
Expand Down
Loading