Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use cancelFilterAnimation guard instead of isAnimating() in draw() - Render labels only for nodes_central during animation (match normal path) - Simplify animated dimmed wrappers to pure alpha fade (no color snap) - Handle all node types in animated label wrapper (not just contributors) - Fade arcs with animAlpha during filter transition - Reduce base hover link opacity to 0.7 so pulse band is visible - Increase glow intensity and radius for better visibility Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Filter animation now uses normal drawing wrappers with globalAlpha instead of separate dimmed wrappers with color snapping. All elements (links, nodes, arcs, labels) fade uniformly. Pulse base opacity lowered from 0.7 to 0.3 for visible contrast with the bright band. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously, all nodes used original-color wrappers during filter transitions, causing already-filtered nodes to flash their original colors. Now tracks which nodes/links were dimmed before the filter change and renders them with gray dimmed wrappers throughout the animation. Also slows pulse to 800ms with wider band. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Phase 1: Contributor start dates for data accuracy Phase 2: Monthly commit histograms + timeline slider UI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The traveling band and breathing approaches both had poor complexity-to-value ratios. Filter fade and node glow provide sufficient hover feedback without the pulse. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
✨ Preview deployed to S3! Visit http://ds-preview-contributor-network-88.s3-website-us-west-2.amazonaws.com/ |
gadomski
reviewed
Mar 24, 2026
Collaborator
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Is there any way to make the transition a bit smoother? Feels jumpy, currently:
Screen.Recording.2026-03-24.at.06.14.03.mov
easeOut front-loads the change which feels abrupt. easeInOut provides a smoother, more natural transition for filter animations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add crossfade for becoming-dimmed items (original fades out while gray fades in with sqrt curve to prevent brightness dip) - Restructure animation draw path to two-tier z-order matching the static filtered view, eliminating the visual "jump" on first frame - Increase animation duration from 300ms to 700ms - Hide tooltip on hover of filtered-out nodes (show label only) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds a checkmarked "All organizations" option at the top of the org filter flyout that clears all selections and closes the dropdown. Updates tests to use data-org selectors instead of index-based option selection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
@gadomski Good push to smooth it out. I think it's much better now. There's still a small initial jump but I could see us spinning our wheels trying to get that last little bit perfect. |
Collaborator
|
On my hotel wifi, the first transition is still pretty jumpy, though it eventually fades out. I personally don't love it, and would probably just stick to a insta-change if we can't make it smooth? Screen.Recording.2026-03-25.at.05.46.25.mov |
aboydnw
force-pushed
the
feat/chart-animations
branch
from
d42a119 to
06c4759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Played around with a couple finishing touches to add a bit more polish: