어포던스: Focus·Caret·Rename과 다중 클릭을 닫는다 - #469
Open
developer-1px wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #468
기반: #459
Goal Anchor
이미 닫힌 손으로 이동한다. 문서의 사용 예시와 실제 package export·반환 계약이 일치한다. 각 손이 적합한 기존 제품 화면에서 직접 사용된다. package 단위 테스트와 제품 경로 브라우저 테스트로 사용 증거가 남는다.구현
focusAffordance로 Order의 roving focus를 selection과 분리했다.renameAffordance와item.rename으로 F2·느린 double-click begin, Enter commit, Escape cancel을 연결했다.caretAffordance·caretCursor를 Document textarea에 붙이고 DOM이 계산한 범위를 Editing selection으로 전달했다.clickCountAffordance의 2회·3회 입력을 Document 제품 경로에서 사용했다.AffordancePreview/applyAffordance계약으로 고치고 메인 카탈로그의 닫힌 손으로 이동했다.검증
npm run verify -w @interactive-os/json-document-affordance(21 tests)npm run verify -w @interactive-os/json-document-editing(55 tests)npm run typecheck -w @interactive-os/json-document-sitenpm test -w @interactive-os/json-document-site(32 tests)npm run docs:evaluatenpx playwright test --config site/playwright.config.ts site/tests/browser/editor-slice-demos.spec.ts --workers=2 --reporter=line(14 passed; ⌘/Ctrl+C·V·Z 포함)npm run build