Repository navigation
Conversation
thesiti92
changed the title
thesiti92
force-pushed
the
share-peek-rows
branch
from
November 2, 2026 02:14
2d8deac to
b824108
Compare
Released Desktops parse downloaded bundles with strict schemas, so any field a newer sharer adds fails their share import. Readers now drop unknown fields in the bundle, its snapshot and its presentation, so a Desktop opens any later bundle. A hosted share's peeks pair base and head excerpts with jsdiff, so a selection on new code, which has no base excerpt, prints as plain code. The bundle gains an optional `alignments` field, one entry per run of the sharer's diff with 1-based base and head line pairs, and the viewer paints from it when present: a null side is added or removed, a differing pair is removed then added. Ranges no run reaches keep the jsdiff pairing. Nothing writes the field yet; the exporter waits on `share-peek-rows-export` until loose-schema Desktops have rolled out. `@dev.fast/review-share-protocol` 0.4.1, `@dev.fast/canvas` 0.3.4. Agent-Session: 845c0993-e0a1-45e7-84a3-caa8eec4d49f Agent-Session: 61c94475-694a-4e46-8971-e0d703d3b344 Agent-Session: e033b653-84f5-4ec8-8eeb-d3a3af5312c5 Agent-Session: f2f8f3d8-5a50-4c15-8ad8-9c9308d4a110 Agent-Session: 64182dea-534e-45f1-8e28-c1e27a5d6bab
thesiti92
force-pushed
the
share-peek-rows
branch
from
November 2, 2026 02:15
b824108 to
fc28604
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Released Desktops parse downloaded bundles with strict zod schemas, so
any field a newer sharer adds fails their share import. Readers now drop
unknown fields in the bundle, its snapshot and its presentation, so a
Desktop opens any later bundle.
A hosted share's peeks pair base and head excerpts with jsdiff, so a
selection on new code, which has no base excerpt, prints as plain code.
Most peeks on a PR board are new code.
alignmentsfield: one entry per run ofthe sharer's diff, with 1-based base and head line pairs and null for
a line the other side lacks.
side is added or removed, a pair with differing text is removed then
added. Ranges no run reaches keep the jsdiff pairing.
share-peek-rows-exportuntil Desktops with the loose schema haverolled out, since a bundle with the field would fail import on every
strict Desktop. It needs a rework to whole-file rows before it lands.
@dev.fast/review-share-protocol0.4.1 and@dev.fast/canvas0.3.4;cloudboard Bump shell-quote from 1.8.4 to 1.10.0 in /apps/review-desktop/code-oss/test/automation #53 pins them.