Skip to content

Add disallowed Features page - #756

Merged
Christof Marti (chrmarti) merged 2 commits into
gh-pagesfrom
chrmarti/brave-otter
Nov 20, 2026
Merged

Christof Marti (chrmarti) merged 2 commits into
gh-pagesfrom
chrmarti/brave-otter

Conversation

@chrmarti

@chrmarti Christof Marti (chrmarti) commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds a containers.dev page at /disallowed-features that explains why dev container tools refuse to use a Feature listed in the control manifest's disallowedFeatures, and what users and Feature authors should do about it. Control manifest entries can link to it from their documentationURL, which the dev container CLI appends to its error and the Dev Containers extension shows as a Learn More button.

Session Context

Key decisions from the development session:

  • Why the page is needed: Disallowed entries are being added for collections whose publishing GitHub account was renamed or deleted, so the name can now be reused by someone else (see Remove entries of renamed or deleted accounts and add owner IDs #755). Those entries can't link to the original repositories because the new name holder controls them. No existing page on containers.dev or code.visualstudio.com covers disallowed Features.
  • containers.dev rather than code.visualstudio.com: The error and learnMoreUrl also show up in the plain dev container CLI, Codespaces and other spec-implementing tools, so the page is tool-neutral. The VS Code-specific dev.containers.defaultFeatures setting is mentioned only as an example.
  • Linked through aka.ms: Manifest entries will use https://aka.ms/dev-container-disallowed-features, to be redirected to this page once it is live, so the target can move without updating the manifest.
  • Page structure: Modeled on supporting.md (singlePage layout, anchored headings). It is reached from the error link, so it isn't added to the top nav.
  • Error text: Quoted from the dev container CLI (src/spec-node/disallowedFeatures.ts). A running container is only stopped when opening or starting a dev container, not on a standalone devcontainer build.
  • Matching rules: The featureIdPrefix description matches the CLI's matcher: the prefix must equal the ID or be followed by /, : or @, and it is case-sensitive.
  • Reporting: Points to the registry hosting the Feature, matching the guidance on the Available Features page. The repository's SECURITY.md only covers Microsoft-owned repositories, and the control manifest's source repository isn't public, so neither is linked.
  • Verified: Built with the GitHub Pages Jekyll image (ghcr.io/actions/jekyll-build-pages); the page renders and all relative links resolve.

Changes

  • disallowed-features.md: new page covering the error users see, why a Feature can be disallowed, what to do, guidance for Feature authors, how to report a problematic Feature, and the disallowedFeatures entry format.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The documentation misdirects third-party abuse reports, links to an inaccessible repository, and incorrectly implies that a rejected standalone build stops a running container.

3 open issues
What changed in this PR

Adds a tool-neutral help page at /disallowed-features for users directed there by dev container errors, including cases involving renamed or deleted publisher accounts.

Changes:

  • Explains why Features are disallowed and how users can remove or replace them.
  • Provides guidance for Feature authors and reporting problematic Features.
  • Documents the control manifest’s matching rules and documentation links.
File Description
disallowed-features.md Adds the disallowed Features help page with remediation guidance and control-manifest documentation.

Review effort: Balanced

Comment thread disallowed-features.md Resolved
Comment thread disallowed-features.md Resolved
Comment thread disallowed-features.md Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@chrmarti
Christof Marti (chrmarti) marked this pull request as ready for review November 20, 2026 09:13
@chrmarti
Christof Marti (chrmarti) requested a review from a team as a code owner November 20, 2026 09:13
@chrmarti
Christof Marti (chrmarti) merged commit d851518 into gh-pages Nov 20, 2026
6 checks passed
@chrmarti
Christof Marti (chrmarti) deleted the chrmarti/brave-otter branch November 20, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants