Repository navigation
Conversation
Contributor
|
Overlaps with #597, which also adds an s shortcut to star. |
Member
|
Closing as a duplicate of #597. Thanks for the work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds keyboard shortcut support for starring or unstarring commits, making it easier for users to interact with commit cards using the keyboard. The main changes include passing a shortcut prop to the
CommitStarButton, updating tooltip and accessibility attributes, and documenting the shortcut in the keyboard shortcuts dialog.Keyboard shortcut integration:
keyShortcutprop (set to"s") to theCommitStarButtoncomponent incommit-card.tsx, enabling the "s" key to star or unstar the focused commit. [1] [2] [3]CommitStarButtonto use thekeyShortcutprop for tooltip display and accessibility, including setting thearia-keyshortcutsattribute and showing the shortcut in the tooltip.Documentation and discoverability: