Skip to content

feat: add star keyboard shortcut - #889

Closed
onairmarc wants to merge 1 commit into
dev-null-sh:productionfrom
onairmarc:production
Closed

onairmarc wants to merge 1 commit into
dev-null-sh:productionfrom
onairmarc:production

Conversation

@onairmarc

Copy link
Copy Markdown

This pull request adds keyboard shortcut support for starring or unstarring commits, making it easier for users to interact with commit cards using the keyboard. The main changes include passing a shortcut prop to the CommitStarButton, updating tooltip and accessibility attributes, and documenting the shortcut in the keyboard shortcuts dialog.

Keyboard shortcut integration:

  • Added a keyShortcut prop (set to "s") to the CommitStarButton component in commit-card.tsx, enabling the "s" key to star or unstar the focused commit. [1] [2] [3]
  • Updated the CommitStarButton to use the keyShortcut prop for tooltip display and accessibility, including setting the aria-keyshortcuts attribute and showing the shortcut in the tooltip.

Documentation and discoverability:

  • Added the "s" key shortcut to the keyboard shortcuts dialog, describing its use for starring or unstarring the focused commit.

@hbenabdallah

Copy link
Copy Markdown
Contributor

Overlaps with #597, which also adds an s shortcut to star.

@nunomaduro

Copy link
Copy Markdown
Member

Closing as a duplicate of #597. Thanks for the work on this!

@nunomaduro nunomaduro closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants