Repository navigation
Conversation
…how media in quotes - Images open in an in-app viewer instead of a new tab: attached images in the composer (with Remove) and posted images in the log. Arrows, ←/→, swipe, Esc. - `s` stars and `b` saves the focused commit, listed in the `?` dialog. - Clicking Log while on the log scrolls to the top and loads new commits. - Quote embeds show the quoted commit's first image as a side thumbnail under a gradient, with a +N count for the rest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Closing as superseded: every part of this has since landed or is tracked elsewhere. Composer image previews shipped in #945, posted images open in the photo viewer from #144, quoted commits render their images ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quality-of-life improvements around images and the keyboard.
View images in place
prefers-reduced-motion.image-viewer.tsx), mounted once inapp.tsxand opened withviewImages(), soCommitImagesstays hook-free.Keyboard
sstars andbsaves the focused commit (j/k), using the existingaria-keyshortcutsdispatch. Both are listed in the?dialog and shown in the buttons' titles.Scroll to top
Media in quote embeds
+Ncount for the rest, so the full image is still a click away on the original. Text-only quotes are unchanged.withQuotedCommitFor()and the moderation queue eager-loadimageson quoted commits, with no extra query per commit (covered by the existing N+1 test). Deleted quoted commits still serialize as tombstones with no images.Notes
Testing
tests/Unit/CommitImagePicker.test.tsxcovering the preview and remove controls.production:CommitRestorationControllerTeststill uses the renamedLog::Everyone, andDatabaseTestneeds Postgres.s/bshortcuts and Log scroll-to-top. Layout shift was ≈0.🤖 Generated with Claude Code