Skip to content

fix: show follows-you tags in following lists - #1434

Open
josephmiclaus wants to merge 1 commit into
dev-null-sh:productionfrom
josephmiclaus:feat/following-follows-you
Open

josephmiclaus wants to merge 1 commit into
dev-null-sh:productionfrom
josephmiclaus:feat/following-follows-you

Conversation

@josephmiclaus

@josephmiclaus josephmiclaus commented Nov 3, 2026 •

Copy link
Copy Markdown

Summary

Following lists omit "Follows you" beside people who follow you. Show the existing tag on both your own Following list and another person's Following list.

Preserve the tag behavior on Followers (see #1354), including hiding it on your own Followers list (see #1357)

View Before After
Another person's Following image image
Your Following image image

Summary by CodeRabbit

  • Bug Fixes
    • The “Follows you” badge now appears in both Followers and Following lists when the person follows you.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The “Follows you” badge can now appear in both Followers and Following lists when the listed person follows the viewer. Tests cover badge visibility in both tabs, including the viewer’s own Following list.

Changes: Follows you badge

Layer / File(s) Summary
Badge condition and tests
resources/js/pages/user/connections.tsx, tests/Unit/FollowState.test.tsx
The badge condition includes Following rows and still requires person.follows_you. Tests check the badge in Followers and Following tabs, including the viewer’s own Following list.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: richardkeep

Merge Risk: Minimal · up to be4e8

The badge eligibility change matches the stated behavior and is covered by the updated Following and Followers tests.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: showing “Follows you” tags in Following lists.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38ef8703-1aa9-4b53-8e6d-e5f31bb40e53
Commits

Reviewing files that changed from the base of the PR and between d99cd27 and be4e8da.

Files selected for processing: 2
  • resources/js/pages/user/connections.tsx
  • tests/Unit/FollowState.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant