Skip to content

ci: execute TSX unit tests with Vite+ in frontend job - #1433

Draft
MrPunyapal wants to merge 2 commits into
dev-null-sh:productionfrom
MrPunyapal:fix/run-tsx-unit-tests-in-frontend-ci
Draft

MrPunyapal wants to merge 2 commits into
dev-null-sh:productionfrom
MrPunyapal:fix/run-tsx-unit-tests-in-frontend-ci

Conversation

@MrPunyapal

@MrPunyapal MrPunyapal commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The existing unit-test command runs Node tests matching tests/Unit/*.test.ts. It skips the .test.tsx tests that use Vite+ APIs, leaving those frontend regressions out of CI.

Change

Add a Vite+ test run for the TSX unit tests to the frontend CI job, alongside the existing Node unit-test step.

Validation

The new CI workflow check has not run successfully yet. This PR should remain in draft until the frontend job runs the TSX tests on GitHub.

Summary by CodeRabbit

  • Tests
    • Automated validation now includes frontend TSX test files, helping ensure interface changes are checked as part of the project’s test suite.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

No actionable comments were generated in the recent review.

Walkthrough

The frontend test workflow adds a step that runs tests/Unit/*.test.tsx with Vite Plus.

Changes: Frontend TSX tests

Layer / File(s) Summary
Add TSX test execution
.github/workflows/tests.yml
The frontend test job runs vp test run tests/Unit/*.test.tsx in a new step.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • dev-null-sh/dev-null.sh#1220: This PR changes TSX test discovery to use globs and Vite Plus. This change also runs a TSX glob through Vite Plus in frontend CI.
  • dev-null-sh/dev-null.sh#1130: This PR identifies a TSX test discovery gap. This change adds a Vite Plus command for matching TSX test files in CI.

Suggested reviewers: nunomaduro, xheaven

Merge Risk: Minimal · previous review f8a1b

The workflow adds the intended TSX test coverage and is ready for the normal CI run.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding Vite+ TSX unit test execution to the frontend CI job.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5b673be3-8354-44d2-8787-3f3af76f8ad7
Commits

Reviewing files that changed from the base of the PR and between c934501 and f8a1b4b.

Files selected for processing: 1
  • .github/workflows/tests.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@MrPunyapal
MrPunyapal marked this pull request as ready for review November 3, 2026 12:41
@MrPunyapal
MrPunyapal marked this pull request as draft November 3, 2026 12:41
@MrPunyapal
MrPunyapal force-pushed the fix/run-tsx-unit-tests-in-frontend-ci branch from 68354be to f1ae8ad Compare November 3, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant