You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: execute TSX unit tests with Vite+ in frontend job - #1433
The existing unit-test command runs Node tests matching tests/Unit/*.test.ts. It skips the .test.tsx tests that use Vite+ APIs, leaving those frontend regressions out of CI.
Change
Add a Vite+ test run for the TSX unit tests to the frontend CI job, alongside the existing Node unit-test step.
Validation
The new CI workflow check has not run successfully yet. This PR should remain in draft until the frontend job runs the TSX tests on GitHub.
Summary by CodeRabbit
Tests
Automated validation now includes frontend TSX test files, helping ensure interface changes are checked as part of the project’s test suite.
dev-null-sh/dev-null.sh#1220: This PR changes TSX test discovery to use globs and Vite Plus. This change also runs a TSX glob through Vite Plus in frontend CI.
dev-null-sh/dev-null.sh#1130: This PR identifies a TSX test discovery gap. This change adds a Vite Plus command for matching TSX test files in CI.
Suggested reviewers:nunomaduro, xheaven
Merge Risk: Minimal · previous review f8a1b
The workflow adds the intended TSX test coverage and is ready for the normal CI run.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: adding Vite+ TSX unit test execution to the frontend CI job.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 5b673be3-8354-44d2-8787-3f3af76f8ad7
Commits
Reviewing files that changed from the base of the PR and between c934501 and f8a1b4b.
Files selected for processing: 1
.github/workflows/tests.yml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing unit-test command runs Node tests matching
tests/Unit/*.test.ts. It skips the.test.tsxtests that use Vite+ APIs, leaving those frontend regressions out of CI.Change
Add a Vite+ test run for the TSX unit tests to the frontend CI job, alongside the existing Node unit-test step.
Validation
The new CI workflow check has not run successfully yet. This PR should remain in draft until the frontend job runs the TSX tests on GitHub.
Summary by CodeRabbit